Feature/private pages (PR 579 rebased) #694
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added functions and types for handling private pages.
Added a handler predicate, unlessPrivatePage, that takes two handlers as arguments and runs the first if the requested page is not listed as a private page, otherwise it runs the fallback handler. Also wired up the predicate with the default gitit settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The feature allowing private pages is interesting. I simply rebased the PR #579 commits and all works! In response to the initial pull request, I've added some documentation on how it works.
For the sake of completeness, it would be preferable for these private pages to be filtered in the pages "All pages" or "Recent activity", but I'm unable to do that in haskell 😢
Do you think this feature could be merged as it stands?