Add support for AzureDefaultCredential-based auth #178
+72
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headcr4sh
commented
May 17, 2024
| @@ -50,18 +50,15 @@ public class AZURE_PINGDiscoveryTest { | |||
| public void testProtocolStack() throws Exception { | |||
| JChannel channel = new JChannel(STACK_XML_CONFIGURATION); | |||
|
|
|||
| channel.getProtocolStack().getProtocols().replaceAll(protocol -> { | |||
There was a problem hiding this comment.
Just an automatic conversion that my IDE performed to use "try-with-resources".
headcr4sh
commented
May 17, 2024
| @@ -63,7 +63,7 @@ | |||
|
|
|||
| <properties> | |||
| <version.org.jgroups>5.3.6.Final</version.org.jgroups> | |||
| <version.com.microsoft.azure.azure-storage>8.6.6</version.com.microsoft.azure.azure-storage> | |||
| <version.com.azure-azure-sdk-bom>1.2.23</version.com.azure-azure-sdk-bom> | |||
|
|
|||
| <!-- Overridden versions as managed by WildFly --> | |||
There was a problem hiding this comment.
I did not check if the updated Azure SDK components still cause issues here or (worse) in other parts of the dependency tree....
|
Upon a brief look the changes look pretty good to me! Excellent work. So what I think I will do, is that I ll move to new major branch as this bumps the SDK, pull your changes in, polish and test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this PR contains a lot more changes than initially intended.
Seems like the coordinates of the Azure Storage Client library have changed and the API of the implementation was completely overhauled as well.
I took the time to try and adhere to current best practices when working with the Azure SDK for Java, e.g. utilizing the bills-of-material (BOM) dependency to make sure that all Azure-related libraries fit together, nicely.
I did not (yet) test the new library in my Cloud environment, but wanted to get this drafted PR out of the door as soon as possible to gather some feedback from the original maintainer.
@rhusar
Closes: #177