-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[React] Numeric field of an entity is sent as a string in the JSON via REST API #23850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qmonmert Thank you for addressing this issue. 🙂
I'll comment on the points I've noticed.
generators/react/templates/src/main/webapp/app/shared/util/entity-utils.ts.ejs
Outdated
Show resolved
Hide resolved
Actually, I'm currently working on a generator for integration tests using Testing Library and MSW to increase test coverage for React entities. It's still under construction, but it generates code like the following: I discovered issues #23763 and #23769 during the development process. |
@qmonmert Thank you for addressing the changes. I've checked them and everything looks good. 😃 This is the section where related entity IDs are sent. The final |
e88c41d
to
474100f
Compare
...tors/react/templates/src/main/webapp/app/entities/_entityFolder_/_entityFile_-update.tsx.ejs
Outdated
Show resolved
Hide resolved
...tors/react/templates/src/main/webapp/app/entities/_entityFolder_/_entityFile_-update.tsx.ejs
Outdated
Show resolved
Hide resolved
Adding a bug bounty, seems lot of work |
@DanielFran thanks |
6f4a34f
to
ec029f8
Compare
...tors/react/templates/src/main/webapp/app/entities/_entityFolder_/_entityFile_-update.tsx.ejs
Outdated
Show resolved
Hide resolved
@mshima always the same build fails :/ |
The failure is related to jdl not loading the databaseType into entity. It’s considering the postgres (gateway) primary key default (Long instead of UUID). |
We should add a warning for microservice entities to use custom id. |
@mshima thanks for the help 🙂 |
@qmonmert approved |
Fix #23763
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.