Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split feign client generator #24457

Merged
merged 4 commits into from
Dec 5, 2023
Merged

split feign client generator #24457

merged 4 commits into from
Dec 5, 2023

Conversation

mshima
Copy link
Member

@mshima mshima commented Dec 4, 2023

Split feign-client generator to reduce unused files.

  • feign client is not used by default, looks an leftover of old microservice support.
  • OAuthIdpTokenResponseDTO is currently generated for every oauth2 app, but only used by feign. Move to feign-client and cleanup.
  • add migration for new option, enable feignClient for old applications, disabled for new applications.
  • add option/prompt/jdl support.

Fixes #20102


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@mshima mshima marked this pull request as ready for review December 5, 2023 03:31
@DanielFran DanielFran merged commit e29d870 into jhipster:main Dec 5, 2023
47 checks passed
@mshima mshima deleted the feign branch December 5, 2023 10:27
@deepu105 deepu105 added this to the 8.1.0 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate simplifying gateway/microservice oauth2 config.
4 participants