Merge pull request #11233 from murdos/suppress-warnings-approvals-config

feat(approval-tests): suppress warnings on PackageSettings
jhipster · Oct 27, 2024 · b9d761a · b9d761a
2 parents 754cdbc + 1f2d633
commit b9d761a
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/sonar-project.properties b/sonar-project.properties
@@ -29,8 +29,7 @@ sonar.exclusions=\
   target/classes/static/**/*.*,\
   src/main/glyph/css/**
 sonar.test.exclusions=\
-  src/test/resources/**,\
-  src/test/java/tech/jhipster/lite/PackageSettings.java
+  src/test/resources/**
 
 sonar.typescript.tsconfigPath=tsconfig.json
 

diff --git a/...in/resources/generator/server/javatool/approvaltesting/test/PackageSettings.java.mustache b/...in/resources/generator/server/javatool/approvaltesting/test/PackageSettings.java.mustache
@@ -8,6 +8,7 @@ import org.approvaltests.reporters.FirstWorkingReporter;
 /**
  * ApprovalTests.Java configuration.
  * */
+@SuppressWarnings({ "unused", "java:S115" })
 public class PackageSettings {
 
   private static final String ApprovalBaseDirectory = "../resources";

diff --git a/src/main/resources/generator/server/sonar/sonar-fullstack-project.properties.mustache b/src/main/resources/generator/server/sonar/sonar-fullstack-project.properties.mustache
@@ -24,8 +24,6 @@ sonar.exclusions=\
   {{projectBuildDirectory}}/classes/static/**/*.*,\
   src/main/webapp/app/index.tsx,\
   src/main/webapp/main.ts
-sonar.test.exclusions=\
-  src/test/**/PackageSettings.java
 
 sonar.issue.ignore.multicriteria=S117,S119,S125,S3437,S4502,S4684,S4032,S5778,S1133,S6206,S6437,S6564,UndocumentedApi,S2301,S7027
 

diff --git a/src/main/resources/generator/server/sonar/sonar-project.properties.mustache b/src/main/resources/generator/server/sonar/sonar-project.properties.mustache
@@ -20,8 +20,6 @@ sonar.exclusions=\
   {{projectBuildDirectory}}/classes/static/**/*.*,\
   src/main/webapp/app/index.tsx,\
   src/main/webapp/main.ts
-sonar.test.exclusions=\
-  src/test/**/PackageSettings.java
 
 sonar.issue.ignore.multicriteria=S117,S119,S125,S3437,S4502,S4684,S4032,S5778,S1133,S6206,S6548,S6437,S6471,UndocumentedApi,S2301,S7027
 

diff --git a/src/test/java/tech/jhipster/lite/PackageSettings.java b/src/test/java/tech/jhipster/lite/PackageSettings.java
@@ -1,11 +1,14 @@
 package tech.jhipster.lite;
 
 import org.approvaltests.core.ApprovalFailureReporter;
-import org.approvaltests.reporters.*;
+import org.approvaltests.reporters.AutoApproveWhenEmptyReporter;
+import org.approvaltests.reporters.DiffReporter;
+import org.approvaltests.reporters.FirstWorkingReporter;
 
 /**
  * ApprovalTests.Java configuration.
  * */
+@SuppressWarnings({ "unused", "java:S115" })
 public class PackageSettings {
 
   private static final String ApprovalBaseDirectory = "../resources";