Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move creation of .npmrc file to the init module #10889

Merged
merged 3 commits into from
Sep 18, 2024
Merged

move creation of .npmrc file to the init module #10889

merged 3 commits into from
Sep 18, 2024

Conversation

coder1706
Copy link
Contributor

Fix #10860

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2024

CLA assistant check
All committers have signed the CLA.

@murdos
Copy link
Contributor

murdos commented Sep 17, 2024

@coder1706 : Nice work! Everything looks fine, excepted the formatting of the code.

Usually we just do a npm install, that will setup git commit hooks so that code is formatted automatically.
Here you can fix things manually by running the command npm run prettier:format

@murdos murdos merged commit 8a08978 into jhipster:main Sep 18, 2024
34 checks passed
@murdos
Copy link
Contributor

murdos commented Sep 18, 2024

@CLAassistant : congrats for your first contribution :)

A small tips: you should rebase your branch on main, rather than merge it into your branch. This helps having a cleaner git history ;)

@coder1706
Copy link
Contributor Author

Thank you! 😄 I will keep it in mind next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move creation of .npmrc file to the init module
3 participants