Improve element replacers API #10908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule to not always do the replacement The previous behavior was a bit unexpected since other replacers shortcuts were doing the replacements conditionally. Adapted the react-jwt module, the only one that was relying on the previous behavior.
…, now using notContainingReplacement() strategy
…fy writing replacements
murdos
force-pushed
the
text-regexp-replacers-not-always
branch
2 times, most recently
from
18781de to
042b720
Compare
murdos
force-pushed
the
text-regexp-replacers-not-always
branch
from
042b720 to
83465f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking: change behavior of text() and regex() methods in JHipsterModule to not always do the replacement
The previous behavior was a bit unexpected since other replacers shortcuts were doing the replacements conditionally.
feat(generator): add helper methods in ReplacementCondition to simplify writing replacements