Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init module with target in .gitignore #10923

Closed
wants to merge 2 commits into from
Closed

Init module with target in .gitignore #10923

wants to merge 2 commits into from

Conversation

pascalgrimaud
Copy link
Member

@pascalgrimaud pascalgrimaud changed the title 10873 init with target in gitignore Init module with target in .gitignore Sep 20, 2024
DamnClin
DamnClin reviewed Sep 20, 2024
View reviewed changes
.../domain/ReactCoreModulesFactoryTest.shouldBuildModuleWithStyle.eslint.config.js.approved.txt
@@ -15,6 +15,7 @@ export default typescript.config(
ignores: ['target/'],
},
js.configs.recommended,
...typescript.configs.recommended.map(config => (config.name === 'typescript-eslint/base' ? config : { ...config, files: ['**/*.ts'] })),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really wanted here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I'll push another fix :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, do it plz, so I'll be able to release when back to home

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to push to your branch, so I've open a new PR: #10924

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange lol

@murdos murdos closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murdos murdos murdos left review comments

@DamnClin DamnClin DamnClin approved these changes

Assignees
No one assigned
Labels
area: enhancement 🔧 theme: typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

target/ in .gitignore should come from init
3 participants
@pascalgrimaud @murdos @DamnClin