-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add vue oauth2 keycloak module #10928
Merged
renanfranca
merged 28 commits into
jhipster:main
from
renanfranca:1133-vue-oauth2-keycloak-module
Sep 24, 2024
Merged
add vue oauth2 keycloak module #10928
renanfranca
merged 28 commits into
jhipster:main
from
renanfranca:1133-vue-oauth2-keycloak-module
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmonmert
reviewed
Sep 20, 2024
src/main/resources/generator/client/vue/documentation/vue-authentication-components.md
Outdated
Show resolved
Hide resolved
DamnClin
reviewed
Sep 20, 2024
src/main/resources/generator/client/vue/webapp/app/auth/domain/AuthenticatedUser.ts.mustache
Outdated
Show resolved
Hide resolved
...rator/client/vue/webapp/app/auth/infrastructure/secondary/KeycloakAuthRepository.ts.mustache
Show resolved
Hide resolved
qmonmert
reviewed
Sep 20, 2024
src/main/resources/generator/client/vue/webapp/app/auth/domain/AuthRepository.ts.mustache
Outdated
Show resolved
Hide resolved
qmonmert
reviewed
Sep 20, 2024
...urces/generator/client/vue/webapp/app/auth/infrastructure/secondary/KeycloakHttp.ts.mustache
Outdated
Show resolved
Hide resolved
qmonmert
previously approved these changes
Sep 21, 2024
renanfranca
force-pushed
the
1133-vue-oauth2-keycloak-module
branch
from
September 23, 2024 14:31
61da9e4
to
b54516d
Compare
As I mentioned here: I added the unit tests to ensure this module can be added to the CI pipeline while maintaining the current 100% coverage metric. Once the discussion reaches a consensus, I’ll proceed with refactoring this module accordingly. I am doing this because I want to conclude this issue before moving on to another one ;) cc: @DamnClin , @murdos , @pascalgrimaud and @qmonmert |
renanfranca
force-pushed
the
1133-vue-oauth2-keycloak-module
branch
from
September 24, 2024 18:44
0c57b79
to
b1aeaa9
Compare
…cloakModulesFactory test environment
…2-keycloak module
…onents.md to use promises rather than async/await
…oak module at the ci pipeline
… generate.sh used at ci pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1133
TO-DO:
Add to
tests-ci/generate.sh
this new module atVue app
Add keycloak-js dependency to common package.json
Add tests for the VueOAuth2KeycloakModulesFactory
Add template files to be used by vue-oauth2-keycloak module
Remove unused import added to main.ts
Add package-info.java
Add vue-oauth2-keycloak module configuration
Add cucumber test to vue-oauth2-keycloak module configuration
Fix cucumber test
Improve VueOAuth2KeycloakModulesFactory code by using constants
Use keycloak-js dependency from COMMON package instead of the ANGULAR package
Add vue-authentication-components.md documentation to vue-oauth2-keycloak module
Fix sonar issues at KeycloakHttp.ts.mustache
||
with??
for null coalescing