Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init tikui module #10935

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Init tikui module #10935

merged 3 commits into from
Sep 29, 2024

Conversation

DamnClin
Copy link
Collaborator

@DamnClin DamnClin commented Sep 21, 2024

First step for tikui module. We are working on this in background for some time with @Gnuk

After this, TODO are:

  • support angular (mainly proxy);
  • support react (mainly proxy);
  • add some more style example;
  • create a documentation.

The idea here is to start something in a disabled module so we can move on on this.

@DamnClin DamnClin force-pushed the tikui-module branch 3 times, most recently from bc757f3 to f6b9813 Compare September 21, 2024 15:06
renanfranca
renanfranca previously approved these changes Sep 21, 2024
Copy link
Contributor

@renanfranca renanfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;) ! I noticed that Tikui's Quarkus is much more modularized than what I saw in the JHipster Lite project. I only understood the placeholder by looking at the code. I will learn more about the spacing when i have the time to apply the module.

I also observed that in the token, the value is set directly in the :root and SCSS variables are not used. I understood this to be a standard for all tokens, and if a component does not want to use the standard, it defines the value directly in the .scss.

Do you not recommend creating SCSS variables in the style definitions of the components?

Thank you for your work! @DamnClin and @Gnuk

Copy link
Contributor

@murdos murdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things that could also be done:

  • prettier plugin for pug
  • eslint plugin for pug
  • amend lint-staged for css/scss =>run stylint --fix and prettier
  • amend lint-staged for pug => run eslint and prettier

@DamnClin
Copy link
Collaborator Author

Do you not recommend creating SCSS variables in the style definitions of the components?

As always, in Software Development you are either in a Complicated or Complex context in Cynefin definitions so there is no one size feet all solution. It always depends on the context

@DamnClin
Copy link
Collaborator Author

Things that could also be done:

* prettier plugin for pug

* eslint plugin for pug

* amend lint-staged for css/scss =>run stylint --fix and prettier

* amend lint-staged for pug => run eslint and prettier

No idea on how to do that (haven't look at it at all) do you have any example (I can do the module no problem)

@murdos
Copy link
Contributor

murdos commented Sep 22, 2024

No idea on how to do that (haven't look at it at all) do you have any example (I can do the module no problem)

BTW this can be done is a later stage, I was mainly sharing my thoughts while reading the PR.

amending lint-staged can now be done with the preCommitActions(..) API on JHipsterModuleBuilder. It can however just add new entry, not altering existing one - and that would be required here for removing css and scss from the main entry added by prettier.

Prettier plugin for pug, besides adding the npm dependency, will require patching the .prettierrc to declare the plugin

Regarding eslint plugin for pug I don't know the details, but I know that it's used on the code of jhlite.

murdos
murdos previously approved these changes Sep 22, 2024
@DamnClin
Copy link
Collaborator Author

No idea on how to do that (haven't look at it at all) do you have any example (I can do the module no problem)

BTW this can be done is a later stage, I was mainly sharing my thoughts while reading the PR.

amending lint-staged can now be done with the preCommitActions(..) API on JHipsterModuleBuilder. It can however just add new entry, not altering existing one - and that would be required here for removing css and scss from the main entry added by prettier.

Prettier plugin for pug, besides adding the npm dependency, will require patching the .prettierrc to declare the plugin

Regarding eslint plugin for pug I don't know the details, but I know that it's used on the code of jhlite.

I'll create dedicated issues for those points

@DamnClin
Copy link
Collaborator Author

Updated proxy for angular, cc @qmonmert is this the "angular" way to do that?

@DamnClin DamnClin merged commit 34748e8 into jhipster:main Sep 29, 2024
34 checks passed
@DamnClin DamnClin deleted the tikui-module branch September 29, 2024 13:32
@pascalgrimaud pascalgrimaud added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ labels Sep 29, 2024
@pascalgrimaud
Copy link
Member

Adding a bounty to reward the big work done here

@DamnClin
Copy link
Collaborator Author

@pascalgrimaud
Copy link
Member

Approved :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: client $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants