-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init tikui module #10935
Init tikui module #10935
Conversation
bc757f3
to
f6b9813
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ;) ! I noticed that Tikui's Quarkus is much more modularized than what I saw in the JHipster Lite project. I only understood the placeholder by looking at the code. I will learn more about the spacing when i have the time to apply the module.
I also observed that in the token, the value is set directly in the :root and SCSS variables are not used. I understood this to be a standard for all tokens, and if a component does not want to use the standard, it defines the value directly in the .scss.
Do you not recommend creating SCSS variables in the style definitions of the components?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things that could also be done:
- prettier plugin for pug
- eslint plugin for pug
- amend lint-staged for css/scss =>run stylint --fix and prettier
- amend lint-staged for pug => run eslint and prettier
src/main/resources/generator/client/tikui/tikuiconfig.json.mustache
Outdated
Show resolved
Hide resolved
f6b9813
to
276cd09
Compare
As always, in Software Development you are either in a Complicated or Complex context in Cynefin definitions so there is no one size feet all solution. It always depends on the context |
No idea on how to do that (haven't look at it at all) do you have any example (I can do the module no problem) |
BTW this can be done is a later stage, I was mainly sharing my thoughts while reading the PR. amending lint-staged can now be done with the Prettier plugin for pug, besides adding the npm dependency, will require patching the .prettierrc to declare the plugin Regarding eslint plugin for pug I don't know the details, but I know that it's used on the code of jhlite. |
I'll create dedicated issues for those points |
276cd09
to
698260f
Compare
Updated proxy for angular, cc @qmonmert is this the "angular" way to do that? |
698260f
to
e353849
Compare
Adding a bounty to reward the big work done here |
Claimed https://opencollective.com/generator-jhipster/expenses/222055, thanks a lot @pascalgrimaud |
Approved :-) |
First step for tikui module. We are working on this in background for some time with @Gnuk
After this, TODO are:
The idea here is to start something in a disabled module so we can move on on this.