Fix invalid if condition in Github Actions #10957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of an
if:
entry is already an expression block, so usage of${{ }}
is not necessary, except in one rare case (https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/using-conditions-to-control-job-execution).However, it is easy to accidentally create an invalid condition:
${{ matrix.java-build-tool }} == 'maven'
will always evaluate to true, due to a quirk of how nested expression context are evaluated.Correct is either
${{ matrix.java-build-tool == 'maven' }}
matrix.java-build-tool == 'maven'
I've choosen to use the latter as it is simpler.
I've also cleaned up unnecessary use of
${{ }}
in other if blocks.