Add jooq module with maven #11107

fabienpuissant · 2024-10-12T23:04:44Z

ci test not relevant because need a database up to install with this jooq plugin, cannot test on mssql. Error to connect due to url error.

See #9235

pascalgrimaud · 2024-10-31T07:34:05Z

for the CI test, you can create a new dedicated config with what you need to test jooq

Another idea would be to add it to mariadb, it should work: https://github.com/jhipster/jhipster-lite/blob/main/tests-ci/generate.sh#L232-L239

fabienpuissant · 2024-10-31T16:52:20Z

for the CI test, you can create a new dedicated config with what you need to test jooq

Another idea would be to add it to mariadb, it should work: https://github.com/jhipster/jhipster-lite/blob/main/tests-ci/generate.sh#L232-L239

But the plugin connects to a database to introspect schema and generate classes depending on what tables exists.
Is it possible in the test ci to have a docker container up with a database ready to be connected to ?

pascalgrimaud · 2024-10-31T19:03:29Z

Here some steps in the GitHub CI:

we launch the containers here:
- https://github.com/jhipster/jhipster-lite/blob/main/.github/workflows/github-actions.yml#L484
- it will use this start_docker_compose.sh script which will launch the appropriate docker-compose file
after that, we'll start the application here:
- https://github.com/jhipster/jhipster-lite/blob/main/.github/workflows/github-actions.yml#L490
- it will at least test the health management. See https://github.com/jhipster/jhipster-lite/blob/main/tests-ci/start.sh#L36

fabienpuissant · 2024-11-01T02:11:18Z

Here some steps in the GitHub CI:

we launch the containers here:

https://github.com/jhipster/jhipster-lite/blob/main/.github/workflows/github-actions.yml#L484

it will use this start_docker_compose.sh script which will launch the appropriate docker-compose file

after that, we'll start the application here:

https://github.com/jhipster/jhipster-lite/blob/main/.github/workflows/github-actions.yml#L490

it will at least test the health management. See https://github.com/jhipster/jhipster-lite/blob/main/tests-ci/start.sh#L36

I started to investigate on it but in fact the db needs to be up at compile time not when we start the app, so on step "Test: verify: " Regarding the workflow, I don't think we have this use case and I don't find a proper way to do it

Here an example : https://github.com/fabienpuissant/jhipster-lite/actions/runs/11622943610/job/32369374084

murdos · 2024-11-10T21:02:54Z

src/main/java/tech/jhipster/lite/module/domain/jooqplugin/JooqModuleCodegenConfiguration.java

@@ -0,0 +1,140 @@
+package tech.jhipster.lite.module.domain.jooqplugin;


I don't thinks this should be in module/domain, this is too specif.
How about moving that in the jooq/domain? (and remove the addition in JHipsterModule)

yep + solve deplicate issue about database enum

murdos · 2024-11-10T21:12:53Z

...a/tech/jhipster/lite/generator/server/springboot/database/jooq/domain/JooqModuleFactory.java

+          .build()
+      )
+      .and()
+      .mavenPlugins()


NB : gradle should be supported too, by configuration the gradle plugin. See https://www.jooq.org/doc/latest/manual/code-generation/codegen-gradle/
But this must be done in a second PR. Meanwhile you can require maven as a dependency of all jooq module in JooqModuleConfiguration to prevent them from being used with gradle.

murdos · 2024-11-10T21:21:29Z

src/main/java/tech/jhipster/lite/module/domain/jooqplugin/JooqModuleCodegenConfiguration.java

+          <inputSchema>%s</inputSchema>
+        </database>
+        <target>
+          <packageName>org.jooq.codegen</packageName>


IMO this should rather be the packageName from properties (e.g. generates classes to com.my.company rather than org.jooq.codegen)

murdos · 2024-11-10T21:28:17Z

src/test/features/server/springboot/database/jooq-mariadb.feature

+      | mariadb.md |
+    And I should have files in "src/main/docker"
+      | mariadb.yml |
+    And I should have files in "src/main/resources/config"


This one is already created by the spring-boot module, so I guess you want have a finer-grained assertion like

Suggested change

And I should have files in "src/main/resources/config"

And I should have "jdbc:mariadb://localhost:3306/" in "src/main/resources/config/application.yml"

murdos · 2024-11-14T06:09:57Z

LGTM. @fabienpuissant : could you rebase the branch to fix conflicts?

…t test on mssql

github-actions bot added the area: triage label Oct 12, 2024

fabienpuissant marked this pull request as draft October 12, 2024 23:05

murdos added area: feature request 💡 server: java theme: database and removed area: triage labels Oct 14, 2024

fabienpuissant force-pushed the jooq-module branch 4 times, most recently from bed27c6 to b9a7721 Compare October 30, 2024 21:51

fabienpuissant changed the title ~~[WIP] Add jooq module~~ Add jooq module Oct 30, 2024

fabienpuissant marked this pull request as ready for review October 30, 2024 21:52

fabienpuissant force-pushed the jooq-module branch from b9a7721 to ddf6d78 Compare October 31, 2024 00:57

fabienpuissant force-pushed the jooq-module branch 2 times, most recently from cd0a545 to 771dfef Compare November 10, 2024 21:00

murdos reviewed Nov 10, 2024

View reviewed changes

fabienpuissant changed the title ~~Add jooq module~~ Add jooq module on maven Nov 10, 2024

fabienpuissant changed the title ~~Add jooq module on maven~~ Add jooq module with maven Nov 10, 2024

fabienpuissant force-pushed the jooq-module branch 3 times, most recently from b6fac3e to de6b01b Compare November 11, 2024 00:15

murdos enabled auto-merge November 14, 2024 06:08

murdos previously approved these changes Nov 14, 2024

View reviewed changes

fabienpuissant added 2 commits November 14, 2024 07:14

WIP working but need to be reworked, add feature test, ci test, canno…

c63bb4c

…t test on mssql

add jooq module with default maven codegen

42678fa

auto-merge was automatically disabled November 14, 2024 06:15
Head branch was pushed to by a user without write access

fabienpuissant dismissed murdos’s stale review via 42678fa November 14, 2024 06:15

fabienpuissant force-pushed the jooq-module branch from de6b01b to 42678fa Compare November 14, 2024 06:15

murdos merged commit ee8c881 into jhipster:main Nov 14, 2024
36 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add jooq module with maven #11107

Add jooq module with maven #11107

fabienpuissant commented Oct 12, 2024 •

edited by murdos

Loading

pascalgrimaud commented Oct 31, 2024

fabienpuissant commented Oct 31, 2024 •

edited

Loading

pascalgrimaud commented Oct 31, 2024

fabienpuissant commented Nov 1, 2024

murdos Nov 10, 2024

fabienpuissant Nov 10, 2024

murdos Nov 10, 2024

murdos Nov 10, 2024

murdos Nov 10, 2024

murdos commented Nov 14, 2024 •

edited

Loading

		@@ -0,0 +1,140 @@
		package tech.jhipster.lite.module.domain.jooqplugin;

	And I should have files in "src/main/resources/config"
	And I should have "jdbc:mariadb://localhost:3306/" in "src/main/resources/config/application.yml"

Add jooq module with maven #11107

Add jooq module with maven #11107

Conversation

fabienpuissant commented Oct 12, 2024 • edited by murdos Loading

pascalgrimaud commented Oct 31, 2024

fabienpuissant commented Oct 31, 2024 • edited Loading

pascalgrimaud commented Oct 31, 2024

fabienpuissant commented Nov 1, 2024

murdos Nov 10, 2024

Choose a reason for hiding this comment

fabienpuissant Nov 10, 2024

Choose a reason for hiding this comment

murdos Nov 10, 2024

Choose a reason for hiding this comment

murdos Nov 10, 2024

Choose a reason for hiding this comment

murdos Nov 10, 2024

Choose a reason for hiding this comment

murdos commented Nov 14, 2024 • edited Loading

fabienpuissant commented Oct 12, 2024 •

edited by murdos

Loading

fabienpuissant commented Oct 31, 2024 •

edited

Loading

murdos commented Nov 14, 2024 •

edited

Loading