fix: lazily run npm install when applying 'prettier' and client modules #11113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me having a look on this solution |
.../java/tech/jhipster/lite/module/infrastructure/secondary/npm/FileSystemNpmLazyInstaller.java
Show resolved
Hide resolved
.../java/tech/jhipster/lite/module/infrastructure/secondary/npm/FileSystemNpmLazyInstaller.java
Show resolved
Hide resolved
.../java/tech/jhipster/lite/module/infrastructure/secondary/npm/FileSystemNpmLazyInstaller.java
Show resolved
Hide resolved
.../java/tech/jhipster/lite/module/infrastructure/secondary/npm/FileSystemNpmLazyInstaller.java
Outdated
Show resolved
Hide resolved
.../java/tech/jhipster/lite/module/infrastructure/secondary/npm/FileSystemNpmLazyInstaller.java
Outdated
Show resolved
Hide resolved
.../java/tech/jhipster/lite/module/infrastructure/secondary/npm/FileSystemNpmLazyInstaller.java
Outdated
Show resolved
Hide resolved
.../java/tech/jhipster/lite/module/infrastructure/secondary/npm/FileSystemNpmLazyInstaller.java
Outdated
Show resolved
Hide resolved
murdos
force-pushed
the
npm-lazy-install
branch
from
8939461 to
6a28d9f
Compare
If a package-lock.json is detected, and npm command is present, run npm install. Fixes jhipster#11106
murdos
force-pushed
the
npm-lazy-install
branch
from
6a28d9f to
ee30e04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a package-lock.json is detected, and npm command is present, run npm install.
Fixes #11106
If we agree on the solution, we should do the same with any module that touches prettier or eslint configuration: