Fix vitest config after prettier format to allow applying front modules #11142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pascalgrimaud
commented
Oct 17, 2024
pascalgrimaud
commented
- related to Fail to apply typescript and vue-core in a second time #11106
murdos
reviewed
Oct 18, 2024
| @@ -29,6 +29,7 @@ export default defineConfig({ | |||
| }, | |||
| include: ['src/main/webapp/**/*.ts?(x)'], | |||
| exclude: [ | |||
| // keep this comment to be able to apply other front module after prettier format | |||
There was a problem hiding this comment.
I'm not really found on this comment that will stay on generated project, just for generation purpose.
I'll try another solution and let you know.
There was a problem hiding this comment.
Agree, it was just the quickest fix in the mean time. Feel free to propose better solution, and rework the replace after lines for each front
There was a problem hiding this comment.
Here's an alternative (that is not perfect either): #11189
There was a problem hiding this comment.
yes, but it's better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.