Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes #11198

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Some fixes #11198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fb682c
Typo: end usually goes with an article
qmonmert Oct 24, 2024
8760f32
Typo: folders=>folder
qmonmert Oct 24, 2024
886ca65
Typo: Use a before consonant sound
qmonmert Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/tech/jhipster/lite/module/domain/replacement/EndOfFileReplacer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import tech.jhipster.lite.shared.generation.domain.ExcludeFromGeneratedCodeCoverage;

/**
* {@link ElementReplacer} that inserts content at end of the file if the provided condition is met
* {@link ElementReplacer} that inserts content at the end of the file if the provided condition is met
* @param condition
*/
public record EndOfFileReplacer(ReplacementCondition condition) implements ElementReplacer {
Expand Down
4 changes: 2 additions & 2 deletions ...ular/admin/src/main/webapp/app/admin/health/modal/health-modal.component.spec.ts.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ describe('HealthModalComponent', () => {
expect(result).toEqual('jhipster');
});

it('should return storage space in an human readable unit (GB)', () => {
it('should return storage space in a human readable unit (GB)', () => {
comp.healthDetails = {
key: 'diskSpace',
status: 'UP',
Expand All @@ -63,7 +63,7 @@ describe('HealthModalComponent', () => {
expect(result).toEqual('1.00 GB');
});

it('should return storage space in an human readable unit (MB)', () => {
it('should return storage space in a human readable unit (MB)', () => {
comp.healthDetails = {
key: 'diskSpace',
status: 'UP',
Expand Down
2 changes: 1 addition & 1 deletion ...t/angular/admin/src/main/webapp/app/admin/health/modal/health-modal.component.ts.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class HealthModalComponent {

readableValue(value: any): string {
if (this.healthDetails.key === 'diskSpace') {
// Should display storage space in an human readable unit
// Should display storage space in a human readable unit
const val = value / this.GIGABYTE;
if (val > 1) {
return `${val.toFixed(2)} GB`;
Expand Down
2 changes: 1 addition & 1 deletion .../generator/client/common/hexagonal-documentation/front-hexagonal-architecture.md.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This documentation is not an introduction to hexagonal architecture. If you want

## Folder structure

in `src/main/webapp/app` root folders represents the bounded contexts. When starting something new, you won't know what
in `src/main/webapp/app` root folder represents the bounded contexts. When starting something new, you won't know what
Bounded Context you're in. Don't spend too much time on that: create a folder, and you'll rename / move it later.

Let's dive into a Bounded Context (example in vue.js, but it's the same for other frontends frameworks):
Expand Down