Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonar: ignore Sections of code should not be commented out #11236

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Sonar: ignore Sections of code should not be commented out #11236

merged 1 commit into from
Oct 30, 2024

Conversation

qmonmert
Copy link
Contributor

Fix #11235

@qmonmert qmonmert force-pushed the sonar271024 branch 7 times, most recently from 8584040 to f7e55e5 Compare October 27, 2024 20:41
@qmonmert
Copy link
Contributor Author

@pascalgrimaud @murdos WDYT? 🙂

@pascalgrimaud
Copy link
Member

Instead of adding this rule in sonar.properties, I would try to ignore the rule directly in the xml file. I'm pretty sure it's possible

@qmonmert
Copy link
Contributor Author

@pascalgrimaud ChatGPT doesn't think so
image

@pascalgrimaud pascalgrimaud merged commit cc02775 into jhipster:main Oct 30, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalgrimaud pascalgrimaud Awaiting requested review from pascalgrimaud

@murdos murdos Awaiting requested review from murdos

Assignees
No one assigned
Labels
area: enhancement 🔧
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sonar: 2 issues on generated app
2 participants
@qmonmert @pascalgrimaud