Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress: fusion of 2 two folders #11308

Closed
wants to merge 1 commit into from

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Nov 5, 2024

No description provided.

Copy link
Contributor

@murdos murdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Component tests and E2E tests are distinct type of tests, and there's no reason to merge the 2 folders that would mean E2E tests would be in the component folder.

If you check generated apps, you can use e.g. Cypress for component tests, and playwright for E2E tests: https://github.com/jhipster/jhipster-lite/blob/main/tests-ci/generate.sh#L186

@qmonmert
Copy link
Contributor Author

qmonmert commented Nov 5, 2024

@murdos here the tests are for the generator

@qmonmert qmonmert marked this pull request as ready for review November 5, 2024 20:45
@murdos
Copy link
Contributor

murdos commented Nov 5, 2024

@murdos here the tests are for the generator

I know.
But why would you structure the generator differently from the generated apps?

@qmonmert
Copy link
Contributor Author

qmonmert commented Nov 5, 2024

For me the folder e2e and component are same (folders with cypress tests): one to test localhost:7471 end the other to test localhost:9000 ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing this E2E?

You don't seem to understand that webapp component tests are testing the webapp with backend requests mocked, whereas E2E tests are testing the webapp with the real backend.
This is not just about using a different port. E2E test are verifying that webapp and backend can correctly communicate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@qmonmert qmonmert closed this Nov 5, 2024
@qmonmert qmonmert reopened this Nov 5, 2024
@qmonmert
Copy link
Contributor Author

qmonmert commented Nov 5, 2024

On vuejwtapp
image
Tests on e2e and component are same (one with cypress, the other with playwright)

@murdos
Copy link
Contributor

murdos commented Nov 5, 2024

On vuejwtapp image Tests on e2e and component are same (one with cypress, the other with playwright)

Yes, the initial content is identical, because we're generating very basics component and E2E tests.
Once you have generated your app, where everything is setup for you, you can start writing real component and/or E2E tests.

BTW, @qmonmert, what issue are you trying to solve with this PR?
You're just describing what is does (fusion of 2 two folders), but not why you're doing it.

@qmonmert qmonmert closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants