-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress: fusion of 2 two folders #11308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Component tests and E2E tests are distinct type of tests, and there's no reason to merge the 2 folders that would mean E2E tests would be in the component
folder.
If you check generated apps, you can use e.g. Cypress for component tests, and playwright for E2E tests: https://github.com/jhipster/jhipster-lite/blob/main/tests-ci/generate.sh#L186
@murdos here the tests are for the generator |
I know. |
For me the folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing this E2E?
You don't seem to understand that webapp component tests are testing the webapp with backend requests mocked, whereas E2E tests are testing the webapp with the real backend.
This is not just about using a different port. E2E test are verifying that webapp and backend can correctly communicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Yes, the initial content is identical, because we're generating very basics component and E2E tests. BTW, @qmonmert, what issue are you trying to solve with this PR? |
No description provided.