Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React/ESLint: enable react/react-in-jsx-scope #11489

Closed
wants to merge 1 commit into from

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Dec 2, 2024

No description provided.

@murdos
Copy link
Contributor

murdos commented Dec 2, 2024

@qmonmert : are you sure that this rule should be enabled?

See https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/react-in-jsx-scope.md

If you are using the new JSX transform from React 17, you should disable this rule by extending react/jsx-runtime in your eslint config (add "plugin:react/jsx-runtime" to "extends").

@qmonmert
Copy link
Contributor Author

qmonmert commented Dec 2, 2024

@murdos I see that it is what we do on the JH generator, but maybe it's not a good idea

@qmonmert qmonmert closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants