add unit test step in gradle ci #11547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renanfranca
reviewed
Dec 8, 2024
Comment on lines
30
to
31
| - name: 'Test: run tests' | ||
| run: ./gradlew clean integrationTest --no-daemon |
There was a problem hiding this comment.
@fabienpuissant : As @atomfrede said before, i think the clean should be removed from that command.
Thanks for fixing that issue!
There was a problem hiding this comment.
absolutely I've done this on my personal repo but not there xD
fabienpuissant
force-pushed
the
fix/run-unit-test-gradle-ci
branch
from
bc7602b to
73164eb
Compare
renanfranca
previously approved these changes
Dec 8, 2024
renanfranca
reviewed
Dec 8, 2024
| @@ -25,5 +25,7 @@ jobs: | |||
| uses: ./.github/actions/setup | |||
| - name: Setup Gradle | |||
| uses: gradle/gradle-build-action@v2 | |||
| - name: 'Test: run unit tests' | |||
| run: ./gradlew clean test --no-daemon | |||
| - name: 'Test: run tests' | |||
There was a problem hiding this comment.
Suggested change
| - name: 'Test: run tests' | |
| - name: 'Test: run integration tests' |
@fabienpuissant : I only saw that now, sorry.
fabienpuissant
force-pushed
the
fix/run-unit-test-gradle-ci
branch
from
73164eb to
10f58d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11513