Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Landscape.vue #7803

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Oct 21, 2023

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c153806) 100.00% compared to head (83366ee) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##                main     #7803   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      2630      2630           
===========================================
  Files            678       678           
  Lines          11545     11545           
  Branches         248       248           
===========================================
  Hits           11545     11545           
Files Coverage Δ
.../webapp/app/module/primary/landscape/Landscape.vue 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qmonmert qmonmert force-pushed the tikui/Landscape branch 2 times, most recently from cbbf9cb to 3f4e719 Compare October 21, 2023 17:34
@qmonmert qmonmert marked this pull request as ready for review October 21, 2023 17:37
@qmonmert
Copy link
Contributor Author

@pascalgrimaud I think we can merge like that, no <style lang="scss"> in Vue components now 🙂
After that, we could improve Tikui adding all components (already created) in atom, molecule, organism... And working on
CSS files (tikui CSS vs globals CSS) in the project

@qmonmert
Copy link
Contributor Author

@pascalgrimaud moreover if you can test this PR to see if CSS is not broken because the Landscape is the main component 🙂

@pascalgrimaud
Copy link
Member

I think it's not exactly the same page than in main branch:
image

Your current PR:
image

  • green module
  • some thing in minimap too

@qmonmert
Copy link
Contributor Author

thanks @pascalgrimaud 🙂 fixed

@pascalgrimaud pascalgrimaud merged commit 3e59087 into jhipster:main Oct 22, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring: Landscape.vue
2 participants