Skip to content

Commit

Permalink
Improve-test-coverage - JHipsterService
Browse files Browse the repository at this point in the history
  • Loading branch information
roexber committed Oct 15, 2020
1 parent 9a7b68d commit e983619
Show file tree
Hide file tree
Showing 118 changed files with 191 additions and 126 deletions.
1 change: 0 additions & 1 deletion src/main/java/io/github/jhipster/online/JhonlineApp.java
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
@SpringBootApplication
@EnableConfigurationProperties({ LiquibaseProperties.class, ApplicationProperties.class })
public class JhonlineApp {

private static final Logger log = LoggerFactory.getLogger(JhonlineApp.class);

private final Environment env;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
*/
@Aspect
public class LoggingAspect {

private final Environment env;

public LoggingAspect(Environment env) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
*/
@ConfigurationProperties(prefix = "application", ignoreUnknownFields = false)
public class ApplicationProperties {

private JhipsterCmd jhipsterCmd = new JhipsterCmd();

private final Github github = new Github();
Expand Down Expand Up @@ -68,7 +67,6 @@ public Mail getMail() {
}

public static class JhipsterCmd {

private String cmd = "jhipster";
private Integer timeout = 120;

Expand All @@ -90,7 +88,6 @@ public void setTimeout(Integer timeout) {
}

public static class Github {

private String clientId;
private String clientSecret;
private String host = "https://github.com";
Expand Down Expand Up @@ -121,7 +118,6 @@ public void setHost(String host) {
}

public static class Gitlab {

private String clientId;
private String clientSecret;
private String host = "https://gitlab.com";
Expand Down Expand Up @@ -161,7 +157,6 @@ public void setRedirectUri(String redirectUri) {
}

public static class Mail {

private boolean enable;

public void setEnable(boolean enable) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
@EnableAsync
@EnableScheduling
public class AsyncConfiguration implements AsyncConfigurer {

private final Logger log = LoggerFactory.getLogger(AsyncConfiguration.class);

private final TaskExecutionProperties taskExecutionProperties;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
@Configuration
@EnableCaching
public class CacheConfiguration {

private final javax.cache.configuration.Configuration<Object, Object> jcacheConfiguration;

private final javax.cache.configuration.Configuration<Object, Object> statisticsJcacheConfiguration;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
@Configuration
@Profile(JHipsterConstants.SPRING_PROFILE_CLOUD)
public class CloudDatabaseConfiguration extends AbstractCloudConfig {

private final Logger log = LoggerFactory.getLogger(CloudDatabaseConfiguration.class);

private static final String CLOUD_CONFIGURATION_HIKARI_PREFIX = "spring.datasource.hikari";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
* Application constants.
*/
public final class Constants {

// Regex for acceptable logins
public static final String LOGIN_REGEX = "^[_.@A-Za-z0-9-]*$";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@

@Configuration
public class LiquibaseConfiguration {

private final Logger log = LoggerFactory.getLogger(LiquibaseConfiguration.class);

private final Environment env;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
@EnableGlobalMethodSecurity(prePostEnabled = true, securedEnabled = true)
@Import(SecurityProblemSupport.class)
public class SecurityConfiguration extends WebSecurityConfigurerAdapter {

private final TokenProvider tokenProvider;

private final CorsFilter corsFilter;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
*/
@Configuration
public class WebConfigurer implements ServletContextInitializer, WebServerFactoryCustomizer<WebServerFactory> {

private final Logger log = LoggerFactory.getLogger(WebConfigurer.class);

private final Environment env;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
@MappedSuperclass
@EntityListeners(AuditingEntityListener.class)
public abstract class AbstractAuditingEntity implements Serializable {

private static final long serialVersionUID = 1L;

@CreatedBy
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
@Table(name = "jhi_authority")
@Cache(usage = CacheConcurrencyStrategy.NONSTRICT_READ_WRITE)
public class Authority implements Serializable {

private static final long serialVersionUID = 1L;

@NotNull
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
@Table(name = "entity_stats")
@Cache(usage = CacheConcurrencyStrategy.NONSTRICT_READ_WRITE)
public class EntityStats implements Serializable, CompleteDate {

private static final long serialVersionUID = 1L;

@Id
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
@Table(name = "generator_identity")
@Cache(usage = CacheConcurrencyStrategy.NONSTRICT_READ_WRITE)
public class GeneratorIdentity implements Serializable {

private static final long serialVersionUID = 1L;

@Id
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@
@Table(name = "git_company")
@Cache(usage = CacheConcurrencyStrategy.NONSTRICT_READ_WRITE)
public class GitCompany implements Serializable {

private static final long serialVersionUID = 1L;

@Id
Expand Down
1 change: 0 additions & 1 deletion src/main/java/io/github/jhipster/online/domain/Jdl.java
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
@Entity
@Table(name = "jdl")
public class Jdl implements Serializable {

private static final long serialVersionUID = 1L;

@Id
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
@Table(name = "jdl_metadata")
@Cache(usage = CacheConcurrencyStrategy.NONSTRICT_READ_WRITE)
public class JdlMetadata implements Serializable {

private static final long serialVersionUID = 1L;

@Id
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
@Entity
@Table(name = "jhi_persistent_audit_event")
public class PersistentAuditEvent implements Serializable {

private static final long serialVersionUID = 1L;

@Id
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
@Table(name = "sub_gen_event")
@Cache(usage = CacheConcurrencyStrategy.NONSTRICT_READ_WRITE)
public class SubGenEvent implements Serializable, CompleteDate {

private static final long serialVersionUID = 1L;

@Id
Expand Down
1 change: 0 additions & 1 deletion src/main/java/io/github/jhipster/online/domain/User.java
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
@Table(name = "jhi_user")
@Cache(usage = CacheConcurrencyStrategy.NONSTRICT_READ_WRITE)
public class User extends AbstractAuditingEntity implements Serializable {

private static final long serialVersionUID = 1L;

@Id
Expand Down
1 change: 0 additions & 1 deletion src/main/java/io/github/jhipster/online/domain/YoRC.java
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
@Cache(usage = CacheConcurrencyStrategy.NONSTRICT_READ_WRITE)
@JsonDeserialize(using = YoRCDeserializer.class)
public class YoRC implements Serializable, CompleteDate {

private static final long serialVersionUID = 1L;

@Id
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
*/
@Repository
public class CustomAuditEventRepository implements AuditEventRepository {

private static final String AUTHORIZATION_FAILURE = "AUTHORIZATION_FAILURE";

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
* Constants for Spring Security authorities.
*/
public final class AuthoritiesConstants {

public static final String ADMIN = "ROLE_ADMIN";

public static final String USER = "ROLE_USER";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
*/
@Component("userDetailsService")
public class DomainUserDetailsService implements UserDetailsService {

private final Logger log = LoggerFactory.getLogger(DomainUserDetailsService.class);

private final UserRepository userRepository;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
* This exception is thrown in case of a not activated user trying to authenticate.
*/
public class UserNotActivatedException extends AuthenticationException {

private static final long serialVersionUID = 1L;

public UserNotActivatedException(String message) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import org.springframework.security.web.authentication.UsernamePasswordAuthenticationFilter;

public class JWTConfigurer extends SecurityConfigurerAdapter<DefaultSecurityFilterChain, HttpSecurity> {

private final TokenProvider tokenProvider;

public JWTConfigurer(TokenProvider tokenProvider) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
* found.
*/
public class JWTFilter extends GenericFilterBean {

public static final String AUTHORIZATION_HEADER = "Authorization";

private final TokenProvider tokenProvider;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@

@Component
public class TokenProvider {

private final Logger log = LoggerFactory.getLogger(TokenProvider.class);

private static final String AUTHORITIES_KEY = "auth";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
@Service
@Transactional
public class AuditEventService {

private final Logger log = LoggerFactory.getLogger(AuditEventService.class);

private final JHipsterProperties jHipsterProperties;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@

@Service
public class CiCdService {

private final Logger log = LoggerFactory.getLogger(CiCdService.class);

private final LogsService logsService;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.github.jhipster.online.service;

public class EmailAlreadyUsedException extends RuntimeException {

private static final long serialVersionUID = 1L;

public EmailAlreadyUsedException() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
@Service
@Transactional
public class EntityStatsService {

private final Logger log = LoggerFactory.getLogger(EntityStatsService.class);

private final EntityStatsRepository entityStatsRepository;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
@Service
@Transactional
public class GeneratorIdentityService {

private final Logger log = LoggerFactory.getLogger(GeneratorIdentityService.class);

private final GeneratorIdentityRepository generatorIdentityRepository;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@

@Service
public class GeneratorService {

private final Logger log = LoggerFactory.getLogger(GeneratorService.class);

private final ApplicationProperties applicationProperties;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@

@Service
public class GitService {

private final Logger log = LoggerFactory.getLogger(GitService.class);

private final ApplicationProperties applicationProperties;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@

@Service
public class GithubService implements GitProviderService {

private final Logger log = LoggerFactory.getLogger(GithubService.class);

private final GeneratorService generatorService;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@

@Service
public class GitlabService implements GitProviderService {

private final Logger log = LoggerFactory.getLogger(GitlabService.class);

private final GeneratorService generatorService;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package io.github.jhipster.online.service;

public class InvalidPasswordException extends RuntimeException {

private static final long serialVersionUID = 1L;

public InvalidPasswordException() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@

@Service
public class JHipsterService {

public final Logger log = LoggerFactory.getLogger(JHipsterService.class);

private final LogsService logsService;
Expand Down Expand Up @@ -75,7 +74,7 @@ public void generateApplication(String generationId, File workingDir) throws IOE
}

public void runImportJdl(String generationId, File workingDir, String jdlFileName) throws IOException {
this.logsService.addLog(generationId, "Running `jhipster import-jdl");
this.logsService.addLog(generationId, "Running `jhipster import-jdl`");
this.runProcess(
generationId,
workingDir,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
@Service
@Transactional
public class JdlMetadataService {

private final Logger log = LoggerFactory.getLogger(JdlMetadataService.class);

private final JdlMetadataRepository jdlMetadataRepository;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@

@Service
public class JdlService {

private final Logger log = LoggerFactory.getLogger(JdlService.class);

private final LogsService logsService;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@

@Service
public class LogsService {

private final Logger log = LoggerFactory.getLogger(LogsService.class);

private Cache<String, String> logsCache = CacheBuilder.newBuilder().expireAfterWrite(5, TimeUnit.MINUTES).build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
*/
@Service
public class MailService {

private final Logger log = LoggerFactory.getLogger(MailService.class);

private static final String USER = "user";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@

@Service
public class StatisticsService {

private final Logger log = LoggerFactory.getLogger(StatisticsService.class);

private final YoRCService yoRCService;
Expand Down
Loading

0 comments on commit e983619

Please sign in to comment.