fix(707): do not throw if the record-pattern contains dims

.github/workflows/github-ci.yml

@@ -8,8 +8,8 @@ jobs:
     strategy:
       matrix:
         node_version:
-          - 18.x
           - 20.x
+          - 22.x
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v3
@@ -33,15 +33,15 @@ jobs:
         test_repository:
           - e2e-jhipster1
           - e2e-jhipster2
-        node_version: [18.x]
+        node_version: [22.x]
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node_version }}
       - uses: actions/setup-java@v3
         with:
-          java-version: 17.x
+          java-version: 21.x
           distribution: zulu
       - name: Install dependencies
         run: yarn

packages/java-parser/src/productions/classes.js

@@ -158,9 +158,8 @@ export function defineRules($, t) {
     $.SUBRULE($.variableDeclarator);
     $.MANY({
       // required to distinguish from patternList
-      GATE: () =>
-        !tokenMatcher(this.LA(3), t.Identifier) &&
-        !tokenMatcher(this.LA(3), t.Underscore),
+      // TODO: complexify lookahed logic to see if we can avoid backtracking
+      GATE: () => this.BACKTRACK_LOOKAHEAD($.isFollowingVariableDeclarator),
       DEF: () => {
         $.CONSUME(t.Comma);
         $.SUBRULE2($.variableDeclarator);
@@ -732,4 +731,9 @@ export function defineRules($, t) {
       tokenMatcher(this.LA(2).tokenType, t.RSquare)
     );
   });
+
+  $.RULE("isFollowingVariableDeclarator", () => {
+    $.CONSUME(t.Comma);
+    $.SUBRULE2($.variableDeclarator);
+  });
 }

packages/java-parser/test/pattern-matching/pattern-matching-spec.js

@@ -54,4 +54,11 @@ describe("Pattern matching", () => {
       javaParser.parse(input, "componentPatternList")
     ).to.not.throw();
   });
+
+  it("should parse pattern list with dims", () => {
+    const input = `A a, B[] b`;
+    expect(() =>
+      javaParser.parse(input, "componentPatternList")
+    ).to.not.throw();
+  });
 });