chore: upgrade pipeline tests to JHipster 8, Java 17, and Node.js 18/20 #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,65 +9,65 @@ const samplesDir = path.resolve(__dirname, "../samples"); | |||
| const core = [ | |||
| { | |||
| repoUrl: "https://github.com/jhipster/jhipster-sample-app", | |||
| branch: "v7.9.3" | |||
| branch: "main" | |||
There was a problem hiding this comment.
I prefer to keep a fixed version, in order to have more reproducible builds/tests
There was a problem hiding this comment.
Agreed! I originally decided to go with the way things were prior to #588, in case there was a reason that main was used that I wasn't aware of. Just pushed this change! 👍
clementdessoude
requested changes
Oct 29, 2023
There was a problem hiding this comment.
Hello @jtkiesel, I just have one remarks about using fixed version for jhipster samples, but otherwise, it's ok for me !
jtkiesel
force-pushed
the
chore/pipeline-tests-upgrade-jhipster-java-node
branch
from
09b9dc6 to
6c44784
Compare
clementdessoude
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed with this PR:
Upgrades the pipeline tests to JHipster 8, Java 17, and Node.js 18/20. Also upgraded GitHub Actions and repos used for testing to their latest versions (some were necessary upgrades, such as Spring Boot/Framework, others were not).
Relative issues or prs:
Closes #609