Update v.1.3.0 Implementation #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2f72f23.
|
PR 감사합니다! |
jhk1090
reviewed
May 25, 2024
syntaxes/key.tmlanguage.json
Outdated
| "name": "variable.parameter.namu", | ||
| "patterns": [ | ||
| { | ||
| "include": "source.latex" |
There was a problem hiding this comment.
이 부분에서 latex 문법이 컨텐츠에 적용되지 않는데 확인해주실 수 있나요?
There was a problem hiding this comment.
기존 언어를 include하여 구현을 성공했으나, 현재 Markdown All in One 확장에 의존적입니다. 의존성을 README.md에 고지하거나, 타 확장에 의존하지 않도록 tmlang 정보를 내장할 필요가 있습니다.
| () => | ||
| `1단계 문단은 비권장 문법입니다.\n2단계 문단 이상으로 변경할 것을 권장합니다.` | ||
| ); | ||
| createDiagnostics(/^##@(.*)/gm, DiagnosticSeverity.Information, (m) => |
There was a problem hiding this comment.
이 부분은 주석을 풀어버리고 다시 나무마크 문법 하이라이팅으로 처리하는 건 어떨까요?
There was a problem hiding this comment.
고정 주석이 있는 경우 diagnostics 기능으로 밑줄을 긋게 하지 말고, syntax highlighting을 적용하는 선에서 해결하자는 말씀이신가요?
jhk1090
reviewed
May 25, 2024
remove unnecessary task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기존 기능의 일부 오류들을 수정함과 동시에, 단축키와 스니펫을 추가하고 제한적으로나마 일부 linting을 구현했습니다. 상세한 변경 사항은 CHANGELOG.md 및 기타 파일의 변경 사항을 참고해주시기 바랍니다.
우선 제 개발 환경에서는 확장이 정상적으로 동작함을 확인하였으나, 풀 요청 수락 전 검토(테스트)를 진행해주시기 바랍니다.