Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to cap very large position values #1206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix to cap very large position values #1206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/src/video_player/method_channel_video_player.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,11 +217,16 @@ class MethodChannelVideoPlayer extends VideoPlayerPlatform {
) ??
0;

// Sometimes the media server returns a absolute position far greater than
// the datetime instance can handle. This caps the value to the maximum the datetime
// can use.
if (milliseconds > 8640000000000000 || milliseconds < -8640000000000000) return null;

if (milliseconds <= 0) return null;

return DateTime.fromMillisecondsSinceEpoch(milliseconds);
}

@override
Future<void> enablePictureInPicture(int? textureId, double? top, double? left,
double? width, double? height) async {
Expand Down