Update Rust version to build libc on Apple Silicon #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-ml
changed the title
|
1.28 is the MSRV. I have no issue bumping it, but it should be to the lowest version necessary to make things work as expected. |
|
@jhpratt fair enough. I used cargo msrv to determine the MSRV, which is 1.54.0. Updated the PR to use 1.54.0 |
|
@Freaky Any objections? |
|
Nope. I'm particularly looking forward to our MSRV supporting MaybeUninit :) |
|
Merging in that case! I'll let you take charge on using Oh, and the MSRV should be updated in docs. |
thibault-ml
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to address #19
The current version of Rust being used to build is 1.28, which is nearly 5 years old.
This leads to
libcnot compiling on macOS (Apple Silicon) in the tests.This change updates Rust to 1.76.0, the latest version as of the writing of this ticket.