Skip to content

Commit

Permalink
Always use package.json mixin
Browse files Browse the repository at this point in the history
  • Loading branch information
Johennes committed Nov 15, 2024
1 parent 0b08caa commit 88fb39c
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 20 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/compat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,9 @@ jobs:
rn-version:
- 0.76.0
- 0.76.1
package-json-mixin:
- none
- package.codegen-output-dir.json

runs-on: ${{ matrix.runner }}
name: "bob ${{ matrix.bob-version }} / rn ${{ matrix.rn-version }} / ${{ matrix.package-json-mixin }} / ${{ matrix.runner == 'macos-latest' && 'ios' || 'android' }}"
name: "bob ${{ matrix.bob-version }} / rn ${{ matrix.rn-version }} / ${{ matrix.runner == 'macos-latest' && 'ios' || 'android' }}"

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -56,6 +53,6 @@ jobs:
--ubrn-config integration/fixtures/compat/ubrn.config.yaml \
--builder-bob-version ${{ matrix.bob-version }} \
--rn-version ${{ matrix.rn-version }} \
--packgage-json-mixin integration/fixtures/compat/${{ matrix.package-json-mixin }} \
--packgage-json-mixin integration/fixtures/compat/package.json \
--${{ matrix.runner == 'macos-latest' && 'ios' || 'android' }} \
../turbo-module
15 changes: 0 additions & 15 deletions integration/fixtures/compat/package.codegen-output-dir.json

This file was deleted.

8 changes: 8 additions & 0 deletions integration/fixtures/compat/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"codegenConfig": {
"outputDir": {
"ios": "ios/tmp",
"android": "android/tmp"
}
}
}

0 comments on commit 88fb39c

Please sign in to comment.