Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translates cli into javascript #102

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Translates cli into javascript #102

merged 1 commit into from
Sep 30, 2024

Conversation

jhugman
Copy link
Owner

@jhugman jhugman commented Sep 30, 2024

This PR translates the command line launcher in to JS.

This means it can be launched from package.json.

Adding to package.json:

"scripts": {
    "ubrn": "uniffi-bindgen-react-native"
}

means now we can do:

yarn ubrn --help

As a little extra:

alias ubrn=$(yarn ubrn --path)

will make the command invokable from the shell.

@jhugman jhugman requested a review from zzorba September 30, 2024 19:36
Copy link
Collaborator

@zzorba zzorba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@jhugman jhugman merged commit 0c36911 into main Sep 30, 2024
1 check passed
@jhugman jhugman deleted the jhugman/reup-cli branch September 30, 2024 20:06
@jhugman jhugman mentioned this pull request Oct 1, 2024
jhugman added a commit that referenced this pull request Oct 2, 2024
#102 changed the `bin` entries in `package.json`. This turned out to be
incorrect.

It worked in development because I was copying the files into `.bin`,
when I should've been soft linking them.

This PR reverts that change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants