Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation publishing #110

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Fix documentation publishing #110

merged 1 commit into from
Oct 3, 2024

Conversation

ianthetechie
Copy link
Contributor

Super cool project! I get a bunch of React Native requests for a library I work on and am looking forward to giving this a try!

I noticed when looking for docs that you've got GitHub pages set up, but it's not easy to find, since it's under an html subdirectory right now: https://jhugman.github.io/uniffi-bindgen-react-native/html/. I figured this out after downloading the CI artifact.

I think this tweak to the workflow will make the docs more accessible. Might also want to link it in the repo metadata on GitHub so there's a link right there on the right side, but I can't open a PR for that ;)

@jhugman jhugman self-requested a review October 3, 2024 16:27
Copy link
Owner

@jhugman jhugman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for jumping in!

I think this tweak to the workflow will make the docs more accessible. Might also want to link it in the repo metadata on GitHub so there's a link right there on the right side, but I can't open a PR for that ;)

Let's see; this stuff I find a bit confusing.

I'll merge and then have a look at what happens.

@jhugman jhugman merged commit 0ded7d3 into jhugman:main Oct 3, 2024
1 check passed
@ianthetechie
Copy link
Contributor Author

Let's see; this stuff I find a bit confusing.

You and me both ;)

I'll merge and then have a look at what happens.

Devops these days: "I literally have no way of testing this locally, there is no option but push and see what breaks" 😂

@ianthetechie ianthetechie deleted the patch-1 branch October 3, 2024 17:00
@ianthetechie
Copy link
Contributor Author

Looks like it worked :) https://jhugman.github.io/uniffi-bindgen-react-native/

@jhugman
Copy link
Owner

jhugman commented Oct 5, 2024

Devops these days: "I literally have no way of testing this locally, there is no option but push and see what breaks" 😂

Haha.

Looks like it worked :)

:fistpumpbaby:

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants