Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag property to flat errors #117

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

jhugman
Copy link
Owner

@jhugman jhugman commented Oct 9, 2024

Fixes #111.

According to The Big O of Code Reviews, this is a O(n) change.

This PR adds a tag property and a MyError_Tags enum to flat errors.

to the error template, it adds some testing of the template, and some docs.

@jhugman jhugman requested a review from zzorba October 9, 2024 11:21
Copy link
Collaborator

@zzorba zzorba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhugman jhugman merged commit 4cda9a3 into main Oct 9, 2024
1 check passed
@jhugman jhugman deleted the jhugman/111-flat-errors-with-tags branch October 9, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement for uniffi flat errors
2 participants