Build for selected Android targets #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
commented
Oct 9, 2024
| /// armeabi-v7a, | ||
| /// x86_64, | ||
| /// x86 | ||
| /// arm64-v8a,armeabi-v7a,x86_64,x86 |
There was a problem hiding this comment.
Small usability improvement: I found myself copy pasting this from the help text.
| "{{ t }}" | ||
| {%- if !loop.last %}, {% endif %} | ||
| {%- endfor %} | ||
| } |
| @@ -92,6 +92,9 @@ where | |||
| for<'a> T: Deserialize<'a>, | |||
| { | |||
| let file = file.as_ref(); | |||
| if !file.exists() { | |||
| anyhow::bail!("File {file} does not exist"); | |||
| } | |||
Johennes
reviewed
Oct 9, 2024
crates/ubrn_cli/src/codegen/mod.rs
Outdated
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| pub(crate) trait RenderedFile: DynTemplate { | ||
| fn path(&self, project_root: &Utf8Path) -> Utf8PathBuf; | ||
| fn project_root(&self) -> Utf8PathBuf { | ||
| // This provides a convenience for templates to calculate | ||
| // relative paths between one anoter. |
There was a problem hiding this comment.
Suggested change
| // relative paths between one anoter. | |
| // relative paths between one another. |
Fixes #106 This issue is conceptually simple: we need to add one line to the `build.gradle` template. Driving that line in the file is data about the targets being built. `targets` comes from the `ProjectConfig` (a.k.a. `ubrn.config.yaml`), which makes this straightforward. HOWEVER, `--targets` can be used when building! SO, we can mutate the `ProjectConfig` while we're building. BUT we don't want the second command overwriting the `build.gradle` so carefully specified in the first. ```sh ubrn build android --and-generate --config ubrn.config.yaml --targets aarch64-linux-android,armv7-linux-androideabi ubrn build ios --and-generate --config ubrn.config.yaml ``` THIS MEANT: adding platform specificity to the each of the generated files.
jhugman
force-pushed
the
jhugman/108-only-build-selected-android-targets
branch
from
1078abd to
d90a74a
Compare
|
Just to report back, I've tested this in https://github.com/unomed-dev/react-native-matrix-sdk and it appears to work great. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106
According to The Big O of Code Reviews, this is a O(n) change.
This issue is conceptually simple: we need to add one line to the
build.gradletemplate.Driving that line in the file is data about the targets being built.
targetscomes from theProjectConfig(a.k.a.ubrn.config.yaml), which makes this straightforward.HOWEVER,
--targetscan be used when building!SO, we can mutate the
ProjectConfigwhile we're building.BUT we don't want the second command overwriting the
build.gradleso carefully specified in the first.THIS MEANT: adding platform specificity to the each of the generated files.
Drive-by Review also requested from @Johennes , if interested.