Trim react-native from the name in the same places create-rn-library and Codegen does #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhugman
force-pushed
the
jhugman/109-fixup-react-native-trimming
branch
4 times, most recently
from
5cd24f4 to
75ad20e
Compare
|
I haven't yet got the test running in CI, but I think that can wait for another PR. Marking ready for review. |
jhugman
changed the title
Johennes
reviewed
Oct 11, 2024
crates/ubrn_cli/src/codegen/mod.rs
Outdated
| @@ -264,7 +264,7 @@ mod files { | |||
| templated_file!(IndexTs, "index.ts"); | |||
There was a problem hiding this comment.
Should this also end in .tsx?
There was a problem hiding this comment.
Yes, you're right. I renamed the template file and made this index.tsx to match. I also renamed the IndexTs struct.
Thanks for prompting me out of laziness. :)
jhugman
force-pushed
the
jhugman/109-fixup-react-native-trimming
branch
from
75ad20e to
07855bd
Compare
jhugman
force-pushed
the
jhugman/109-fixup-react-native-trimming
branch
from
07855bd to
47d5ef0
Compare
jhugman
added a commit
that referenced
this pull request
Oct 16, 2024
Fixes #124 According to [The Big O of Code Reviews](https://www.egorand.dev/the-big-o-of-code-reviews/), this is a O(_n_) change. This adds to the tests introduced in #123 to support names with an org name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109.
This PR adds testing around the turbo-modules.
The tests runs through a host of different names, then
create-react-native-librarywith that name.ubrn generate turbo-modulecommandcreate-react-native-libraryfilesThis has meant a series of changes (for the better) to the templates.