Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For #139 - Pulls sentence about yarn into an info block #142

Merged
merged 2 commits into from
Oct 24, 2024
Merged

For #139 - Pulls sentence about yarn into an info block #142

merged 2 commits into from
Oct 24, 2024

Conversation

boek
Copy link
Collaborator

@boek boek commented Oct 24, 2024 •
edited
Loading

This patch pulls the sentence about requiring yarn into an info block to help users not to miss this step.

image

Johennes
Johennes approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@Johennes Johennes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The info box is a great idea, thank you! Just left one optional comment.

docs/src/guides/pre-installation.md Outdated Show resolved Hide resolved
@boek boek merged commit 0486689 into jhugman:main Oct 24, 2024
5 checks passed
@boek boek deleted the i139 branch October 24, 2024 19:00
@jhugman jhugman mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johennes Johennes Johennes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boek @Johennes