Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the configuration errors in the document about ubrn.config.yaml #154

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

kingsword09
Copy link
Contributor

There's a problem with the android configuration in the ubrn.config.yaml file in the document.

When I configure android according to the document, the following error occurs:

# Error: Failed to read "ubrn.config.yaml" as valid YAML

# Caused by:
#     android.targets[0]: unknown variant `aarch64-linux-android`, expected one of `armeabi-v7a`, `arm64-v8a`, `x86`, `x86_64` at line 10 column 5

After looking at the code, I found that it does need to be changed to Abi armeabi-v7a, arm64-v8a, x86, x86_64.

Copy link
Collaborator

@Johennes Johennes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and evidently matches what e.g. https://github.com/unomed-dev/react-native-matrix-sdk/blob/main/ubrn.yaml#L10 uses.

@jhugman
Copy link
Owner

jhugman commented Nov 6, 2024

Brilliant! Thanks @kingsword09 .

I'll investigate further why this was failing (it shouldn't) but will merge this nevertheless. Thank you.

@jhugman jhugman merged commit c6f2185 into jhugman:main Nov 6, 2024
5 checks passed
@kingsword09 kingsword09 deleted the fix/fix-typo branch November 7, 2024 00:32
@kingsword09
Copy link
Contributor Author

Brilliant! Thanks @kingsword09 .

I'll investigate further why this was failing (it shouldn't) but will merge this nevertheless. Thank you.

Because the target used in the template is used for ndk abiFilters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants