Prevent further prompts in npx create-react-native-library #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johennes
commented
Nov 9, 2024
| @@ -165,7 +165,7 @@ create_library() { | |||
| example_type=vanilla | |||
| fi | |||
| echo "-- Creating library $PROJECT_SLUG with create-react-native-library@$BOB_VERSION" | |||
| npx "create-react-native-library@$BOB_VERSION" \ | |||
| npm_config_yes=true npx "create-react-native-library@$BOB_VERSION" \ | |||
There was a problem hiding this comment.
This confirms the install prompt when you haven't run the supplied version of create-react-native-library before.
Need to install the following packages:
[email protected]
Ok to proceed? (y)
Johennes
commented
Nov 9, 2024
| @@ -175,6 +175,7 @@ create_library() { | |||
| --languages cpp \ | |||
| --type module-new \ | |||
| --example $example_type \ | |||
| --local false \ | |||
There was a problem hiding this comment.
This declines generating a local library when running the script from the root folder of another project (such as ubrn itself).
? Looks like you're under a project folder. Do you want to create a local library? › (Y/n)
|
There seems to be a timing issue on the CI that makes the abort-controller test flake occasionally. That should be unrelated to the changes in this PR though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should make it easier to run
test-turbo-modules.shon the CI in future.