Fix CLI working without an extension #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzorba
changed the title
zzorba
force-pushed
the
dsalinas/fix_cli_without_extension
branch
from
e35982e to
75c1194
Compare
|
It would be sad if the package can't be ESM, just because of this 🤔
|
jhugman
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
This looks fine.
You should also add the .cjs to https://github.com/jhugman/uniffi-bindgen-react-native/blob/main/scripts/test-turbo-modules.sh#L71 and https://github.com/jhugman/uniffi-bindgen-react-native/blob/main/bin/cli.cjs#L35.
I'll approve this now so as not to wait for another round of feedback.
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.