Coverall2 and Rondpoint working with WASM! #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
TextEncoder
andTextDecoder
.FinalizationRegistry
.This is in service of getting the
rondpoint
fixture running.Several things to note here:
error: rondpointpm::Optionneur is a private type
Structs which derive the
uniffi::Object
currently need to have visibilitypub
. If they're not, then errors like:error: rondpointpm::Optionneur is a private type
are shown.This is due to
uniffi-rs
generating a public C ABI which uses the private struct as part of its trait bounds. This feels like it's a Rust bug (I hate saying that).Next steps:
uniffi-rs
could generate a simpler ABI which didn't contain the private type.uniffi-rs
could prevent non-pub
structsuniffi-bindgen-react-native
should add this to a trouble-shooting page.Additing a procmacro version of rondpoint and coverall2
This is due to mozilla/uniffi-rs#2329 not yet being release.
Since we have now released to CocoaPods and npm, I can build against uniffi-main. This is o k a y for a little project like this, but I do worry about that a chem-spill requiring a rapid fix and release may get messy.
Default attribute values not seeming to work in proc-macro
uniffi::Record
I don't seem to be able to get default attributes working for records going: as in the typescript isn't getting generated. If this is a bug, this is almost certainly a uniffi-rs bug. Will file.