Simplify React name trimming function. #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzorba
force-pushed
the
trim-name
branch
3 times, most recently
from
73f5ef4 to
536c59a
Compare
zzorba
force-pushed
the
trim-name
branch
2 times, most recently
from
812f39d to
3a6521d
Compare
jhugman
added a commit
that referenced
this pull request
Sep 27, 2024
According to [The Big O of Code Reviews](https://www.egorand.dev/the-big-o-of-code-reviews/), this is a O(_n_) change. Fixes #44. This PR investigates and fixes how the React Native Codegen file is named, taking into consideration the rules around what it creates. It turns out that it: * has to start with `Native` * it is the file name that is used to generate all the other files * the spec name in pacakge.json seems to be irrelevant. The PR still allows ReactNative and RN to be trimmed, but only if it is not specified in the configuration YAML. E.g. `name: RnDiode` to the top of the `config.yaml`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the way in which we create a trimmed react name, which has downstream implications in a few places. For example, this function is used in generating the
Native___names, spec names, and namespace. Previously, if you named your package RNFoo vs Foo then you would get FooSpec in both cases, as well as placement in the foo namespace. This is specialized knowledge a user of the ubrn would need to know. Whereas now, RNFoo results in RnFooSpec and rnfoo, and Foo results in FooSpec and foo.It's possible I've misunderstood what the point of this was.. just I was having difficulty understanding in what cases I could drop RN, and in what cases Native got prefixed. I'm open to doing something different here, I just want to minimize the surprise from the user's perspective.