Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type to importing of Object interfaces #83

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

jhugman
Copy link
Owner

@jhugman jhugman commented Aug 30, 2024

According to The Big O of Code Reviews, this is a O(n) change.

Fixes #81.

This PR adds type to the imports of types between crates, and reviews what uniffi types should be imported as consts and which as types.

Before:

import { 
  MyObjectInterface, 
  MyCallbackInterface, 
  MyEnum, 
  type MyRecord 
} from "./other-crate"

Now:

import { 
  type MyObjectInterface, 
  type MyCallbackInterface, 
  MyEnum, 
  type MyRecord 
} from "./other-crate"

It also adds a playground test in the testing directory.

@jhugman jhugman requested a review from zzorba August 30, 2024 12:03
@jhugman jhugman force-pushed the jhugman/81-external-type-importing-types branch from ccf7945 to d364536 Compare August 30, 2024 13:34
@jhugman jhugman force-pushed the jhugman/81-external-type-importing-types branch from d364536 to fd61e96 Compare August 30, 2024 13:38
@jhugman jhugman merged commit d6eb76a into main Aug 30, 2024
1 check passed
@jhugman jhugman deleted the jhugman/81-external-type-importing-types branch August 30, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing type designation on some imports from inter-crate dependencies for *Interface types
2 participants