Skip to content

Commit

Permalink
addressed most of the editors' comments to ch1
Browse files Browse the repository at this point in the history
  • Loading branch information
yfain committed Oct 29, 2013
1 parent 82a6a75 commit 3d47536
Show file tree
Hide file tree
Showing 2 changed files with 98 additions and 58 deletions.
32 changes: 28 additions & 4 deletions Addressing_comments_by_TE
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,36 @@ Addressing the comments

Authors agreed with most of the suggestions of the editors. This file includes only the authors' responses to the editors comments if we decided not to make to the book drafts.

Preface,

Introduction, page XIV. We already mentioned Typescript and CoffeeScript. Mentioning Google's Closure compiler wouldn't be needed here.

Ch1, page 4. There is nothing wrong with "In the 90th, JavaScript was considered a second class language"
Ch1, page 12. There is only one table and a paragraph that mention HTML5/browser compatibility - it's not enough for having a section with a subtitle.

Ch1, page 16. Most likely the tech. editor didn't see the option "Run as JavaScript Web project" because he didn't select the project in Aptana before creating New From Template file. It works fine on Mac for us. But I made clarification in the text anyway.

Ch1, page 20. We'll use both FireBug and Chrome Dev tools.

CH1, page 21 - no need to add more explanation here.


Ch1, page 22. No subsections needed for a one-page section on gentle into to function. Also, it's not easy to not create a mess by jumping around from introducing objects without introducing functions and vica versa. I don't think we need to talk much about objects in the section on functions.

Ch1, page 23, this would be ambiguous: "This is useful if you want to delay …" ?"


Ch1, page 25 and 34. I assume that if you don't like the footnotes, the copy editor will replace them with in-code comments. Not sure how they'll do it throughout the book, case in some cases the footnote comments have lots of text.

Ch1, page 30. The tech editor is wrong - Firebug shows the variable this and window without the need to set them as watch variables.


Ch1, page 33. The tech editor is wrong - delete removes the property. Here's the reference:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/delete

Ch1, page 35. Do not remove the line "Printing the object referred by `emp` will output [object Object]."

Ch1, page 35. This is a wrong comment: "I think it'd be better to only use Chrome Developer Tools in this book." Developers use both Firebug and Chrome Dev tools.

Ch1, page 36. Yes, this is the right place for this.


Ch1, page 8. Most likely the tech. editor didn't see the option "Run as JavaScript Web project" because he didn't select the project in Aptana before creating New From Template file. It works fine on Mac for us. But I made clarification in the text anyway.


Loading

0 comments on commit 3d47536

Please sign in to comment.