Deprecate Matrix.ss.diag and Vector.ss.diag (python-graphblas#342)

These have been deprecated since 2022-04-04
jim22k · Dec 19, 2022 · 392596d · 392596d
1 parent a9d0db1
commit 392596d
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 34 deletions.
diff --git a/graphblas/core/ss/matrix.py b/graphblas/core/ss/matrix.py
@@ -244,20 +244,6 @@ def orientation(self):
             return "columnwise"
         return "rowwise"
 
-    def diag(self, vector, k=0):
-        """
-        GxB_Matrix_diag
-
-        **This function is deprecated.  Use ``Vector.diag`` or ``Matrix.ss.build_diag`` instead.**
-
-        """
-        warnings.warn(
-            "`Matrix.ss.diag` is deprecated; "
-            "please use `Vector.diag` or `Matrix.ss.build_diag` instead",
-            DeprecationWarning,
-        )
-        self.build_diag(vector, k)
-
     def build_diag(self, vector, k=0):
         """
         GxB_Matrix_diag

diff --git a/graphblas/core/ss/vector.py b/graphblas/core/ss/vector.py
@@ -1,5 +1,4 @@
 import itertools
-import warnings
 
 import numpy as np
 from numba import njit
@@ -147,20 +146,6 @@ def format(self):
             raise NotImplementedError(f"Unknown sparsity status: {sparsity_status}")
         return format
 
-    def diag(self, matrix, k=0):
-        """
-        GxB_Vector_diag
-
-        **This function is deprecated.  Use ``Matrix.diag`` or ``Vector.ss.build_diag`` instead.**
-
-        """
-        warnings.warn(
-            "`Vector.ss.diag` is deprecated; "
-            "please use `Matrix.diag` or `Vector.ss.build_diag` instead",
-            DeprecationWarning,
-        )
-        self.build_diag(matrix, k)
-
     def build_diag(self, matrix, k=0):
         """
         GxB_Vector_diag

diff --git a/graphblas/tests/test_matrix.py b/graphblas/tests/test_matrix.py
@@ -3441,12 +3441,7 @@ def compare(A, expected, isequal=True, **kwargs):
 
 
 def test_deprecated(A):
-    v = A.diag()
     if suitesparse:
-        with pytest.warns(DeprecationWarning):
-            A.ss.diag(v)
-        with pytest.warns(DeprecationWarning):
-            v.ss.diag(A)
         with pytest.warns(DeprecationWarning):
             A.ss.compactify_rowwise()
         with pytest.warns(DeprecationWarning):