fix: 🐛 favor reportUnusedDisableDirectives instead (#41)

jimmy-guzman · Nov 2, 2024 · eb17660 · eb17660
1 parent 2f17fe9
commit eb17660
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 11 deletions.
diff --git a/src/factory.spec.ts b/src/factory.spec.ts
@@ -6,16 +6,22 @@ vi.mock("local-pkg");
 
 describe("jimmyDotCodes", () => {
   describe("base", () => {
-    it.each(["node", "imports", "perfectionist", "unicorn", "eslint-comments"])(
-      "should create configuration w/ %s",
-      (input) => {
-        expect(jimmyDotCodes({ autoDetect: false })).toStrictEqual(
-          expect.arrayContaining([
-            expect.objectContaining({ name: `jimmy.codes/${input}` }),
-          ]),
-        );
-      },
-    );
+    it.each([
+      "node",
+      "imports",
+      "perfectionist",
+      "unicorn",
+      "eslint-comments",
+      "prettier",
+      "ignores",
+      "base",
+    ])("should create configuration w/ %s", (input) => {
+      expect(jimmyDotCodes({ autoDetect: false })).toStrictEqual(
+        expect.arrayContaining([
+          expect.objectContaining({ name: `jimmy.codes/${input}` }),
+        ]),
+      );
+    });
   });
 
   it("should create configuration w/ typescript", () => {

diff --git a/src/factory.ts b/src/factory.ts
@@ -41,7 +41,13 @@ export const jimmyDotCodes = (
   const isAstroEnabled = astro || (autoDetect && hasAstro());
 
   return [
-    { name: "jimmy.codes/base", rules: baseRules },
+    {
+      linterOptions: {
+        reportUnusedDisableDirectives: true,
+      },
+      name: "jimmy.codes/base",
+      rules: baseRules,
+    },
     ...perfectionistConfig(),
     ...nodeConfig(),
     ...unicornConfig(),

diff --git a/src/rules/__snapshots__/eslint-comments.spec.ts.snap b/src/rules/__snapshots__/eslint-comments.spec.ts.snap
@@ -6,6 +6,7 @@ exports[`should create eslintComments rules 1`] = `
   "@eslint-community/eslint-comments/no-aggregating-enable": "error",
   "@eslint-community/eslint-comments/no-duplicate-disable": "error",
   "@eslint-community/eslint-comments/no-unlimited-disable": "error",
+  "@eslint-community/eslint-comments/no-unused-disable": "off",
   "@eslint-community/eslint-comments/no-unused-enable": "error",
   "@eslint-community/eslint-comments/require-description": "error",
 }

diff --git a/src/rules/eslint-comments.ts b/src/rules/eslint-comments.ts
@@ -4,5 +4,6 @@ import type { Rules } from "../types";
 
 export const eslintCommentsRules = {
   ...comments.recommended.rules,
+  "@eslint-community/eslint-comments/no-unused-disable": "off",
   "@eslint-community/eslint-comments/require-description": "error",
 } satisfies Rules;