feat(cli): ✨ add skip when none hint to breaking change prompt

.config/jest.config.js

@@ -3,10 +3,10 @@ module.exports = {
   coveragePathIgnorePatterns: ['node_modules', 'index.ts'],
   coverageThreshold: {
     global: {
-      branches: 97.3,
-      functions: 96.55,
-      lines: 97.28,
-      statements: 97.67,
+      branches: 97.32,
+      functions: 96.64,
+      lines: 97.59,
+      statements: 97.92,
     },
   },
   preset: 'ts-jest',

src/interfaces.ts

@@ -112,3 +112,16 @@ export interface GitzyState {
   answers: Answers
   config: GitzyConfig
 }
+
+interface PromptLang {
+  hint?: string
+  message: string
+}
+
+export interface PromptsLang {
+  body: PromptLang
+  breaking: PromptLang
+  scope: PromptLang
+  subject: PromptLang
+  type: PromptLang
+}

src/prompts/__snapshots__/lang.test.ts.snap

@@ -0,0 +1,27 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`lang promptsLang should create prompts lang 1`] = `
+Object {
+  "body": Object {
+    "hint": "...supports multi line, press enter to go to next line",
+    "message": "Add a longer description
+",
+  },
+  "breaking": Object {
+    "hint": "...skip when none",
+    "message": "Add any breaking changes
+  BREAKING CHANGE:",
+  },
+  "scope": Object {
+    "hint": "...type or use arrow keys",
+    "message": "Choose the scope",
+  },
+  "subject": Object {
+    "message": "Add a short description",
+  },
+  "type": Object {
+    "hint": "...type or use arrow keys",
+    "message": "Choose the type",
+  },
+}
+`;

src/prompts/body.ts

@@ -1,11 +1,11 @@
 import { CreatedPrompt } from '../interfaces'
-import { promptMessages } from './lang'
+import { promptsLang } from './lang'
 
 export const body: CreatedPrompt = () => {
   return {
     format: (value): string => value.trim(),
-    hint: '...supports multi line, press enter to go to next line',
-    message: promptMessages.body,
+    hint: promptsLang.body.hint,
+    message: promptsLang.body.message,
     multiline: true,
     name: 'body',
     type: 'text',

src/prompts/breaking.test.ts

@@ -0,0 +1,28 @@
+import { breaking } from './breaking'
+import { defaultConfig } from '../defaults'
+import { EnquirerPrompt } from '../interfaces'
+
+describe('breaking', () => {
+  it('should create body prompt', () => {
+    const breakingPrompt = breaking({
+      config: defaultConfig,
+      answers: {
+        body: '',
+        breaking: '',
+        issues: '',
+        scope: '',
+        subject: '',
+        type: '',
+      },
+      flags: {},
+    }) as Required<EnquirerPrompt>
+
+    expect(breakingPrompt).toStrictEqual({
+      hint: '...skip when none',
+      message: `Add any breaking changes
+  BREAKING CHANGE:`,
+      name: 'breaking',
+      type: 'text',
+    })
+  })
+})

src/prompts/breaking.ts

@@ -1,9 +1,10 @@
 import { CreatedPrompt } from '../interfaces'
-import { promptMessages } from './lang'
+import { promptsLang } from './lang'
 
 export const breaking: CreatedPrompt = () => {
   return {
-    message: promptMessages.breaking,
+    hint: promptsLang.breaking.hint,
+    message: promptsLang.breaking.message,
     name: 'breaking',
     type: 'text',
   }

src/prompts/lang.test.ts

@@ -0,0 +1,9 @@
+import { promptsLang } from './lang'
+
+describe('lang', () => {
+  describe('promptsLang', () => {
+    it('should create prompts lang', () => {
+      expect(promptsLang).toMatchSnapshot()
+    })
+  })
+})

src/prompts/lang.ts

@@ -1,19 +1,31 @@
-import { bold, red, reset } from 'ansi-colors'
+import { bold, dim, red, reset } from 'ansi-colors'
 
-import { IssuesPrefixes } from '../interfaces'
+import { IssuesPrefixes, PromptsLang } from '../interfaces'
 
 const breaking = red('BREAKING CHANGE:')
 
-const closes = (issuesPrefix: IssuesPrefixes): string => {
-  return reset(`${issuesPrefix}:`)
+export const promptsLang: PromptsLang = {
+  body: {
+    hint: '...supports multi line, press enter to go to next line',
+    message: 'Add a longer description\n',
+  },
+  breaking: {
+    hint: dim('...skip when none'),
+    message: `${bold('Add any breaking changes')}\n  ${breaking}`,
+  },
+  scope: {
+    hint: dim('...type or use arrow keys'),
+    message: 'Choose the scope',
+  },
+  subject: { message: 'Add a short description' },
+  type: {
+    hint: dim('...type or use arrow keys'),
+    message: 'Choose the type',
+  },
 }
 
-export const promptMessages: Record<string, string> = {
-  body: 'Add a longer description\n',
-  breaking: `${bold('Add any breaking changes')}\n  ${breaking}`,
-  scope: 'Choose the scope',
-  subject: 'Add a short description',
-  type: 'Choose the type',
+const closes = (issuesPrefix: IssuesPrefixes): string => {
+  return reset(`${issuesPrefix}:`)
 }
 
 export const issuesMessage = (issuesPrefix: IssuesPrefixes): string => {

src/prompts/scope.ts

@@ -1,8 +1,6 @@
-import { dim } from 'ansi-colors'
-
 import { CreatedPrompt, EnquirerChoice } from '../interfaces'
 import { fuzzySearch } from '../utils'
-import { promptMessages } from './lang'
+import { promptsLang } from './lang'
 
 export const scope: CreatedPrompt = ({ config: { scopes } }) => {
   const choices = scopes.map((s) => ({ indent: ' ', title: s, value: s }))
@@ -11,14 +9,13 @@ export const scope: CreatedPrompt = ({ config: { scopes } }) => {
   return scopes.length > 0
     ? {
         choices,
-        hint: dim('...type or use arrow keys'),
+        hint: promptsLang.scope.hint,
         limit: 10,
-        message: promptMessages.scope,
+        message: promptsLang.scope.message,
         name: 'scope',
         suggest: (input: string): Promise<EnquirerChoice[]> => {
           return fuzzySearch<EnquirerChoice>(choices, input, 'title')
         },
-
         type: 'autocomplete',
       }
     : null

src/prompts/subject.ts

@@ -1,7 +1,7 @@
 import { green, red, yellow, bold } from 'ansi-colors'
 
 import { CreatedPrompt, EnquirerState, Answers } from '../interfaces'
-import { errorMessage, promptMessages } from './lang'
+import { errorMessage, promptsLang } from './lang'
 
 export const leadingLabel = (answers?: Answers): string => {
   const scope =
@@ -15,7 +15,7 @@ export const subject: CreatedPrompt = ({
 }) => {
   const minTitleLengthError = errorMessage.minTitleLength(headerMinLength)
   const maxTitleLengthError = errorMessage.maxTitleLength(headerMaxLength)
-  const message = promptMessages.subject
+  const message = promptsLang.subject.message
   const emojiLength = disableEmoji ? 0 : 3
 
   return {

src/prompts/type.ts

@@ -1,13 +1,11 @@
-import { dim } from 'ansi-colors'
-
 import {
   CreatedPrompt,
   EnquirerChoice,
   Flags,
   GitzyConfig,
 } from '../interfaces'
 import { fuzzySearch } from '../utils'
-import { promptMessages } from './lang'
+import { promptsLang } from './lang'
 
 export const choice = (
   { details, disableEmoji }: GitzyConfig,
@@ -31,9 +29,9 @@ export const type: CreatedPrompt = ({ config, flags }) => {
 
   return {
     choices,
-    hint: dim('...type or use arrow keys'),
+    hint: promptsLang.type.hint,
     limit: 10,
-    message: promptMessages.type,
+    message: promptsLang.type.message,
     name: 'type',
     suggest: (input: string): Promise<EnquirerChoice[]> => {
       return fuzzySearch<EnquirerChoice>(choices, input, 'title')

src/utils/store/utils.test.ts

@@ -86,6 +86,8 @@ describe('utils', () => {
   })
 
   describe('mkdir', () => {
+    const DIR_NAME = 'dirname'
+
     it('should do nothing when directory exists', () => {
       const mkdirSyncSpy = jest
         .spyOn(fs, 'mkdirSync')
@@ -94,10 +96,29 @@ describe('utils', () => {
 
       jest.spyOn(utils, 'directoryExists').mockReturnValueOnce(true)
 
-      utils.mkdir('dirname')
+      utils.mkdir(DIR_NAME)
       expect(mkdirSyncSpy).not.toHaveBeenCalled()
       expect(handleErrorSpy).not.toHaveBeenCalled()
     })
+    it('should do throw when mkdirSync fails', () => {
+      const mkdirSyncSpy = jest
+        .spyOn(fs, 'mkdirSync')
+        .mockImplementationOnce(() => {
+          throw new Error('')
+        })
+      const handleErrorSpy = jest
+        .spyOn(utils, 'handleError')
+        .mockImplementationOnce(jest.fn())
+
+      jest.spyOn(utils, 'directoryExists').mockReturnValueOnce(false)
+
+      utils.mkdir(DIR_NAME)
+
+      expect(mkdirSyncSpy).toHaveBeenNthCalledWith(1, DIR_NAME, {
+        recursive: true,
+      })
+      expect(handleErrorSpy).toHaveBeenNthCalledWith(1, DIR_NAME, new Error(''))
+    })
     it('should call mkdirSync when directory does not exist', () => {
       const mkdirSyncSpy = jest
         .spyOn(fs, 'mkdirSync')
@@ -106,9 +127,9 @@ describe('utils', () => {
 
       jest.spyOn(utils, 'directoryExists').mockReturnValueOnce(false)
 
-      utils.mkdir('dirname')
+      utils.mkdir(DIR_NAME)
 
-      expect(mkdirSyncSpy).toHaveBeenNthCalledWith(1, 'dirname', {
+      expect(mkdirSyncSpy).toHaveBeenNthCalledWith(1, DIR_NAME, {
         recursive: true,
       })
       expect(handleErrorSpy).not.toHaveBeenCalled()