Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 bump node to v20 #19

Merged
merged 3 commits into from
Nov 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/install/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Install everything for the repo
inputs:
node-version:
description: Version of Node to use
default: 18.x
default: 20.x

pnpm-version:
description: Version of pnpm to use
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
- name: 📦 Install
uses: ./.github/actions/install
with:
node-version: 18
pnpm-version: 8.3.1
node-version: 20
pnpm-version: 8.10.5

- name: 🚨 Lint
run: pnpm lint
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ degit jimmy-guzman/react-starter

## Getting Started

Make sure you're using [node 18](https://nodejs.dev/en/about/releases), I recommend using [fnm](https://github.com/Schniz/fnm) which will allow to simply run:
Make sure you're using [node 20](https://nodejs.dev/en/about/releases), I recommend using [fnm](https://github.com/Schniz/fnm) which will allow to simply run:

```
fnm use
Expand Down Expand Up @@ -100,10 +100,10 @@ pnpm format

_you can run `pnpm format:fix` to fix all format errors_

To validate everything, run the following command:
To interactively update dependencies, run the following command:

```
pnpm validate
pnpm deps:update
```

## Recommendations
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@
"vite": "5.0.0",
"vitest": "0.34.6"
},
"packageManager": "pnpm@8.3.1",
"packageManager": "pnpm@8.10.5",
"engines": {
"node": "18",
"pnpm": "8.3.1"
"node": "20",
"pnpm": "8.10.5"
}
}