Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 use modern best practices for tsconfigs #26

Merged
merged 1 commit into from
Nov 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
run: pnpm format

- name: 🏷️ Check Types
run: pnpm check-types
run: pnpm typecheck

- name: ✅ Test
run: pnpm coverage
Expand Down
1 change: 1 addition & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"Parens",
"pnpm",
"tailwindcss",
"typecheck",
"vite",
"vitest",
"zustand"
Expand Down
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,12 @@ pnpm format

_you can run `pnpm format:fix` to fix all format errors_

To check types, run the following command:

```
pnpm typecheck
```

To interactively update dependencies, run the following command:

```
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"dev": "vite",
"build": "vite build",
"preview": "vite preview",
"check-types": "tsc",
"typecheck": "tsc",
"lint": "eslint --color .",
"lint:fix": "pnpm lint --fix",
"format": "prettier --check .",
Expand Down
18 changes: 9 additions & 9 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,17 +1,19 @@
{
"compilerOptions": {
"allowJs": false,
"allowSyntheticDefaultImports": true,
"esModuleInterop": true,
"skipLibCheck": true,
"target": "es2022",
"allowJs": true,
"moduleDetection": "force",
"isolatedModules": true,

"jsx": "react-jsx",
"lib": ["DOM", "DOM.Iterable", "ESNext"],
"module": "ESNext",
"moduleResolution": "Node",
"moduleResolution": "Bundler",
"noEmit": true,
"resolveJsonModule": true,
"target": "ESNext",
"useDefineForClassFields": true,
"esModuleInterop": true,
"skipLibCheck": true,

"forceConsistentCasingInFileNames": true,

"strict": true,
Expand All @@ -26,8 +28,6 @@
"noUnusedLocals": true,
"noUnusedParameters": true,

"verbatimModuleSyntax": true,

"baseUrl": ".",
"paths": {
"@/*": ["src/*"]
Expand Down