Add support for rspec 3 #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of a recent [commit](https://github.com/rspec/rspec-expectations/blame/79582c2c160ac7b3a58d3d128012b022c63d6174/lib/rspec/matchers/built_in/raise_error.rb#L38) to rspec-expectations, Rspec::Matchers::BuiltIn::RaiseError strictly requires a Proc rather than something that quacks like one.
searls
referenced
this pull request
in forever-inc/netsweet
Jan 9, 2015
Reverts half of be0b142 @ronen: it looks like what happened here is that does_not_match#super will pass whatever it is given into `matches?` and as a result, the matcher was never ever being passed an actual ::Given::Failure. This caused all of the (already red) negative cases to remain red even after the patch.
|
Moving this PR to the new repo rspec-given#1 |
|
Insofar as future issues and discussion should be on the new repo so we can actually maintain them: yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mirrored on the new repo here
There are currently 19 failing specs on master when running the latest versions of rspec.
have_failedwith RSpec 3.0.0 #43does_not_match?was inadvertently wrappingGiven::Failureobjects)expecta block when paired with theraise_errormatcherBefore merging, it may make sense to attempt a travis build matrix that maintains rspec 2 support.