fix: Modal throws a11y error (ant-design#50339)

* test: fix ci * chore: upgrade rc-dialog * chore: update snapshot * fix test case
jinshuju · Aug 9, 2024 · 4bc4d7a · 4bc4d7a
1 parent c6116fa
commit 4bc4d7a
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 162 deletions.
diff --git a/.gitignore b/.gitignore
@@ -75,4 +75,6 @@ __image_snapshots__/
 .devcontainer*
 
 # From v5
-locale/
+locale/
+.eslintcache
+server/
diff --git a/components/config-provider/__tests__/__snapshots__/components.test.tsx.snap b/components/config-provider/__tests__/__snapshots__/components.test.tsx.snap
@@ -18491,7 +18491,6 @@ exports[`ConfigProvider components Modal configProvider 1`] = `
         style="width: 520px;"
       >
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />
@@ -18555,7 +18554,6 @@ exports[`ConfigProvider components Modal configProvider 1`] = `
           </div>
         </div>
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />
@@ -18584,7 +18582,6 @@ exports[`ConfigProvider components Modal configProvider componentDisabled 1`] =
         style="width: 520px;"
       >
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />
@@ -18650,7 +18647,6 @@ exports[`ConfigProvider components Modal configProvider componentDisabled 1`] =
           </div>
         </div>
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />
@@ -18679,7 +18675,6 @@ exports[`ConfigProvider components Modal configProvider componentSize large 1`]
         style="width: 520px;"
       >
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />
@@ -18743,7 +18738,6 @@ exports[`ConfigProvider components Modal configProvider componentSize large 1`]
           </div>
         </div>
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />
@@ -18772,7 +18766,6 @@ exports[`ConfigProvider components Modal configProvider componentSize middle 1`]
         style="width: 520px;"
       >
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />
@@ -18836,7 +18829,6 @@ exports[`ConfigProvider components Modal configProvider componentSize middle 1`]
           </div>
         </div>
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />
@@ -18865,7 +18857,6 @@ exports[`ConfigProvider components Modal configProvider virtual and dropdownMatc
         style="width: 520px;"
       >
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />
@@ -18929,7 +18920,6 @@ exports[`ConfigProvider components Modal configProvider virtual and dropdownMatc
           </div>
         </div>
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />
@@ -18958,7 +18948,6 @@ exports[`ConfigProvider components Modal normal 1`] = `
         style="width: 520px;"
       >
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />
@@ -19022,7 +19011,6 @@ exports[`ConfigProvider components Modal normal 1`] = `
           </div>
         </div>
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />
@@ -19051,7 +19039,6 @@ exports[`ConfigProvider components Modal prefixCls 1`] = `
         style="width: 520px;"
       >
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />
@@ -19115,7 +19102,6 @@ exports[`ConfigProvider components Modal prefixCls 1`] = `
           </div>
         </div>
         <div
-          aria-hidden="true"
           style="width: 0px; height: 0px; overflow: hidden; outline: none;"
           tabindex="0"
         />

diff --git a/components/image/__tests__/__snapshots__/index.test.tsx.snap b/components/image/__tests__/__snapshots__/index.test.tsx.snap
@@ -198,7 +198,6 @@ exports[`Image Default Group preview props 1`] = `
           role="dialog"
         >
           <div
-            aria-hidden="true"
             style="width: 0px; height: 0px; overflow: hidden; outline: none;"
             tabindex="0"
           />
@@ -220,7 +219,6 @@ exports[`Image Default Group preview props 1`] = `
             </div>
           </div>
           <div
-            aria-hidden="true"
             style="width: 0px; height: 0px; overflow: hidden; outline: none;"
             tabindex="0"
           />