-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reviews 테스트 작성 #802
Draft
nyj001012
wants to merge
26
commits into
develop
Choose a base branch
from
786-reviews-테스트-작성
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
The head ref may contain hidden characters: "786-reviews-\uD14C\uC2A4\uD2B8-\uC791\uC131"
Draft
reviews 테스트 작성 #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: v1 api와 다른 부분 수정 * refactor: books API schema default sort value 추가 및 callSign 오타 수정 * refactor: status: zod.enum -> zod.nativeEnum 변경 z.enum으로 했을때 number 반환값에 대한 처리가 되지 않아 enumStatus 생성 후 nativeEnum으로 변경하였습니다. * feat: books//:id v2 구현 * feat: books/search v2 구현 * feat: book/update v2 구현 * feat: books/info/:id v2 구현 * refactor: BookNotFoundError import 오타 수정 * feat: books/info/sorted v2 구현 * feat: books/info/tag v2 구현 book_info.id 로 distinct가 되지 않는 오류가 있어요 * refactor: 의미에 맞는 변수명으로 수정 및 코드 간략화 Co-authored-by: scarf <[email protected]> * refactor: book_info 중복 select 부분 처리 Co-authored-by: scarf <[email protected]> * feat: books/donator v2 구현 v1 구현 시 얘기했었던 기부자가 유저가 아니더라도 수정될 수 있도록 수정 & email은 더이상 관리하지 않기 때문에 변수명에서 제거 * refactor: 대출 가능 여부 boolean 반환값으로 수정 kysely 사용중 select가 없을 경우 sql syntax 에러로 해당 부분 수정 및 boolean 값 반환되도록 수정 * feat: [get] books/create v2 구현 axios.get 동작 중 발생하는 에러(catch 영역)에 대한 처리를 어떻게 해야할지 모르겠어요 * fix: 임시로 타입 오류 무시 --------- Co-authored-by: scarf <[email protected]>
* build: prettier 설정 * style: prettier 적용 --------- Co-authored-by: nocontribute <>
Co-authored-by: kylee <[email protected]>
* refactor: `/stock` 제거 #767 (comment) * refactor: contracts에서 500번대 오류 제거 백엔드에서 복구 불가능한 오류일 시 반환하기 때문에, 프론트엔드에서 따로 처리하는 것이 좋을 것 같습니다. * refactor: `/history` -> `/lendings` #767 (comment) Co-authored-by: jwoo <[email protected]> * refactor: `/users ` 정리 #767 (comment) Co-authored-by: honeyl3ee <[email protected]> * refactor: `/tag` 서비스 임시 제거 고도화를 하기 위해서는 내부 구현을 바꾸어야 하는 문제가 있어 우선순위를 낮추었습니다. 주석처리를 할까 고민했으나 제거 이전 커밋(1565441)으로 체크아웃시 전체 코드를 확인 가능하기 때문에 복잡도 감소를 위해 코드를 제거하였습니다. * refactor: `/books` 경로 정리 #767 (comment) #767 (comment) Co-authored-by: Jeong Jihwan <[email protected]> Co-authored-by: jwoo <[email protected]> * feat: swagger에서 1줄 요약 표시 --------- Co-authored-by: jwoo <[email protected]> Co-authored-by: honeyl3ee <[email protected]> Co-authored-by: Jeong Jihwan <[email protected]>
토큰에서 id 정보 찾아서 유저 정보 반환하는 controller
searchUsersById 서비스 함수의 종속성이 생각보다 많음.controller 에서 items 의 length 를 확인하도록
…phyeonjeon-42/backend into 778-auth-관련-api-무조건-200-리턴-버그
…리턴-버그 fix: auth 관련 api가 무조건 200 리턴 버그
* refactor: 400번대 에러 반환 제거 * refactor: overDueDay 반환 값에서 제거
* chore(deps): contracts의 pnpm-lock 업데이트 * chore(deps): @mapbox/npm-pre-gyp 설치 * chore(deps): npm-pre-gyp 설치 * Revert "chore(deps): npm-pre-gyp 설치" This reverts commit 8922c38 * chore(deps): package.json과 pnpm-lock.yaml 동기화
Open
nyj001012
temporarily deployed
to
development
November 20, 2023 08:35
— with
GitHub Actions
Inactive
nyj001012
temporarily deployed
to
development
November 27, 2023 07:42
— with
GitHub Actions
Inactive
nyj001012
temporarily deployed
to
development
November 27, 2023 07:43
— with
GitHub Actions
Inactive
nyj001012
temporarily deployed
to
development
November 27, 2023 07:44
— with
GitHub Actions
Inactive
nyj001012
temporarily deployed
to
development
November 27, 2023 07:44
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
v2의 reviews 테스트 코드 작성
작업 사항
insertReviews
테스트변경점
목적
스크린샷 (optional)