Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WM_DESTROY callback must return 0 (fixes TypeError from show_toast()) #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

f3ndot
Copy link

@f3ndot f3ndot commented Jan 22, 2023

fixes #112

The on_destroy method that's called as part of the WM_DESTROY callback must return 0, not none. Otherwise this error will raise when using show_toast():

TypeError: WPARAM is simple, so must be an int object (got NoneType)

@f3ndot f3ndot changed the title WM_DESTROY callback must return 0 WM_DESTROY callback must return 0 (fixes TypeError from show_toast()) Jan 22, 2023
Copy link

@xboxone08 xboxone08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a fix for a minor annoyance, so merging good 👍.

@fspofficial
Copy link

fspofficial commented Aug 2, 2023

I have made much more improved changes by just changing a single line- #118

@xboxone08
Copy link

I have made much more improved changes by just changing a single line- #118

Uhh, yours looks the exact same?

Copy link

@dmtzs dmtzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Python 3.11
8 participants