-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WM_DESTROY
callback must return 0 (fixes TypeError from show_toast()
)
#115
base: master
Are you sure you want to change the base?
Conversation
WM_DESTROY
callback must return 0 (fixes TypeError from show_toast()
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a fix for a minor annoyance, so merging good 👍.
I have made much more improved changes by just changing a single line- #118 |
Uhh, yours looks the exact same? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working correctly
fixes #112
The
on_destroy
method that's called as part of theWM_DESTROY
callback must return 0, not none. Otherwise this error will raise when usingshow_toast()
: