Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional argument to not stream updates on startup #45

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

buffalu
Copy link
Contributor

@buffalu buffalu commented Apr 8, 2024

  • I ran the following on our RPC server during startup: solana-validator -l /solana/ledger set-log-filter debug and saw accounts getting streamed out during snapshot loading
  • This can massively slow down startup
  • Added optional flag that's backwards compatibile (streams by default)

@buffalu buffalu requested a review from segfaultdoc April 8, 2024 03:45
@buffalu buffalu force-pushed the lb/dont_stream_on_startup branch from 9a20db7 to b7e9d4b Compare April 8, 2024 04:06
@buffalu buffalu force-pushed the lb/dont_stream_on_startup branch from fe90f8c to 62d5e6a Compare April 8, 2024 05:40
@buffalu buffalu merged commit 97b1325 into master Apr 8, 2024
4 checks passed
@buffalu buffalu deleted the lb/dont_stream_on_startup branch April 8, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant